Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove mapCoverage remainings; remove deprecated CLI options test #9968

Merged
merged 6 commits into from
Dec 7, 2020

Conversation

thymikee
Copy link
Collaborator

@thymikee thymikee commented May 4, 2020

Summary

Address TODOs around mapCoverage.

Additionally removes the deprecatedCLIOptions test, as this option was the only one deprecated. Leaving a note so we can dig up this PR and revive the test when necessary.

Test plan

CI passes

@thymikee
Copy link
Collaborator Author

thymikee commented May 4, 2020

Is it ok to remove the deprecation warning for mapCoverage? Normally I'd say "keep it for a while" but since it's no longer necessary, I'm willing to remove it completely.

@thymikee thymikee added this to the Jest 26.x milestone May 5, 2020
@SimenB
Copy link
Member

SimenB commented May 6, 2020

I'm down with removing the deprecation warning as well, it has been warning for a few years at this point. Warning was added for the config option

@SimenB SimenB modified the milestones: Jest 26.x, Jest 27 May 6, 2020
@SimenB
Copy link
Member

SimenB commented Dec 5, 2020

@thymikee rebase?

@thymikee
Copy link
Collaborator Author

thymikee commented Dec 5, 2020

Sure, will do tomorrow :)


const dir = path.resolve(__dirname, '../deprecated-cli-options');

it('Prints deprecation warnings for CLI flags', () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having a test for this is useful, but we don't have any other deprecations?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, was wondering if we should keep it empty and leave a comment, "in case of deprecations, test here". You think it makes sense?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure... is that easier than just digging up this PR again?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevertheless, it would be weird to have a "placeholder" test, just in case. I'll edit the OP and adjust the title so it's easier to find when we need it

@thymikee thymikee changed the title chore: remove mapCoverage remainings chore: remove mapCoverage remainings; remove "deprecated CLI options" test Dec 7, 2020
@thymikee thymikee changed the title chore: remove mapCoverage remainings; remove "deprecated CLI options" test chore: remove mapCoverage remainings; remove deprecated CLI options test Dec 7, 2020
@SimenB SimenB merged commit 196e573 into jestjs:master Dec 7, 2020
jeysal added a commit to mattphillips/jest that referenced this pull request Dec 13, 2020
* master: (30 commits)
  chore: verify TS project references are correct (jestjs#10941)
  chore(deps): bump actions/setup-node from v2.1.2 to v2.1.3 (jestjs#10940)
  docs: Rectify typo in tutorialReactNative (jestjs#10930)
  chore: patch react-native jest preprocessor to avoid warning
  Ensure `toContain` only accepts strings when `received` is a string (jestjs#10929)
  chore: update lockfile after publish
  v27.0.0-next.2
  Document and test custom, async, inline snapshot matcher (jestjs#10922)
  feat(transform): pass config options through to transformer (jestjs#10926)
  chore: bump eslint-config-prettier
  chore: run prettier using eslint
  chore: update lockfile after publish
  v27.0.0-next.1
  fix: move binary file declaration from runtime to repl (jestjs#10925)
  chore(test-result): remove deprecated `sourcemap` property (jestjs#10355)
  chore: remove mapCoverage remainings; remove deprecated CLI options test (jestjs#9968)
  refactor(jest-runtime,jest-transform): add readonly for some class fields (jestjs#10918)
  chore: ensure single environment package as well
  chore: fix failing tests (jestjs#10924)
  chore: fix lint warning
  ...
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants