Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please bundle yoga with different package name for React Native compatiliby #522

Closed
ex3ndr opened this issue Apr 1, 2019 · 2 comments
Closed

Comments

@ex3ndr
Copy link

ex3ndr commented Apr 1, 2019

Starting from last RN release there are some huge internal inconsistency in Yoga layer between java version (from maven) and the one from RN itself. I have tried most of recent version of Litho and nothing works with latest releases of React Native. Previous release of RN works just fine.

While that could be a problem on RN side, but RN team have a record ignoring even more important problems and now there are only hope on Litho ream 🙏

Thanks!

@colriot
Copy link
Contributor

colriot commented Apr 12, 2019

We actually don't bundle Yoga with Litho. We depend on a maven/bintray dependency provided as usual.

The thing is that you may get a collision not only on Java API level, but also on a ntive libs level. So, even if they repackage Yoga with jarjra, for example, native Yoga libs will be different as well and will probably collide.

Looks like the one and proper thing here if for them to depend on latest release versions of Yoga.

Can you link RN issue for that here, please? I'll try to highlight it internally.

@xfumihiro
Copy link

xfumihiro commented Jan 5, 2020

@colriot @ex3ndr
facebook/react-native#24459

It seems like RN is depend on latest Yoga c++ version (based on the comment & RN source code) but Litho is depend on 1.16 Yoga java version

so how to safely use Litho with RN?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants