Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add docs for deploy react native fork to npm #22030

Closed
gengjiawen opened this issue Oct 31, 2018 · 3 comments
Closed

[FEATURE] Add docs for deploy react native fork to npm #22030

gengjiawen opened this issue Oct 31, 2018 · 3 comments
Labels
Help Wanted :octocat: Issues ideal for external contributors. Resolution: Locked This issue was locked by the bot.

Comments

@gengjiawen
Copy link
Contributor

gengjiawen commented Oct 31, 2018

Enable this will let community to make patch or share feature easily.

Related issue:
#21776
#21967

cc @kelset

@xzilja
Copy link
Contributor

xzilja commented Oct 31, 2018

As far as I know npm can also install directly from github url, we might just need section in README or docs website that explains how to correctly build forked files.

@hramos posted these #21967 (comment) in one of the issues you mentioned, so thats renderer bit I guess.

@bartolkaruza
Copy link

Github dependency in package.json works fine if you commit the Android binary from installArchives. The build output is in the .gitignore, but if you remove that line you can commit the build on your branch, which then works as a Github dependency. NPM or Maven dependencies for forks require much more effort (imho), which is not worth it considering the fork should be short lived.

@kelset kelset added Help Wanted :octocat: Issues ideal for external contributors. and removed Core Team labels Oct 31, 2018
@kelset
Copy link
Contributor

kelset commented Oct 31, 2018

This to me seems more like an issue for the https://github.com/facebook/react-native-website repo, since that's where the docs live --> facebook/react-native-website#653.

@kelset kelset closed this as completed Oct 31, 2018
@facebook facebook locked as resolved and limited conversation to collaborators Oct 31, 2019
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Oct 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Help Wanted :octocat: Issues ideal for external contributors. Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

5 participants