From 1ba65737614e6ecfc7fffe1506b78fd4a8413837 Mon Sep 17 00:00:00 2001 From: Lauren Tan Date: Fri, 12 Jul 2024 11:06:57 -0400 Subject: [PATCH] [RN] Set enableOwnerStacks and enableUseDeferredValueInitialArg to false In www, the experimental versions get a .modern.js or .classic.js prefix and get copied into the same folder. In RN, they don't seem to have .modern.js and .classic.js versions so they end up getting the same name. sebmarkbage's theory is that what happens is that they then override the file that was already there. So depending on if experimental or stable build finishes first you get a different version at the end. It doesn't make sense to use `__EXPERIMENTAL__` for flags in native-fb since there's no modern/classic split there. So that flag should just be hardcoded to true or false and then it doesn't matter which one finishes first. We don't support experimental builds in OSS RN neither so the same thing could happen with [`enableOwnerStacks`](https://github.com/facebook/react/blob/5dcf3ca8d45a276a8b4cee0cedd234967661ca35/packages/shared/forks/ReactFeatureFlags.native-oss.js#L60). You can see that the build errors in the previous PR but passes after these flag changes. ghstack-source-id: da04295a8f6a7c080d8ed3ebbb4ca5527eabe0e6 Pull Request resolved: https://github.com/facebook/react/pull/30322 --- packages/shared/forks/ReactFeatureFlags.native-oss.js | 2 +- .../shared/forks/ReactFeatureFlags.test-renderer.native-fb.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/shared/forks/ReactFeatureFlags.native-oss.js b/packages/shared/forks/ReactFeatureFlags.native-oss.js index 15caf9713bf75..3ef19e4b127e7 100644 --- a/packages/shared/forks/ReactFeatureFlags.native-oss.js +++ b/packages/shared/forks/ReactFeatureFlags.native-oss.js @@ -57,7 +57,7 @@ export const enableLegacyFBSupport = false; export const enableLegacyHidden = false; export const enableNoCloningMemoCache = false; export const enableObjectFiber = false; -export const enableOwnerStacks = __EXPERIMENTAL__; +export const enableOwnerStacks = false; export const enablePostpone = false; export const enableReactTestRendererWarning = false; export const enableRefAsProp = true; diff --git a/packages/shared/forks/ReactFeatureFlags.test-renderer.native-fb.js b/packages/shared/forks/ReactFeatureFlags.test-renderer.native-fb.js index d5429617569ca..a760c28ea4ae6 100644 --- a/packages/shared/forks/ReactFeatureFlags.test-renderer.native-fb.js +++ b/packages/shared/forks/ReactFeatureFlags.test-renderer.native-fb.js @@ -69,7 +69,7 @@ export const enableTaint = true; export const enableTransitionTracing = false; export const enableTrustedTypesIntegration = false; export const enableUpdaterTracking = false; -export const enableUseDeferredValueInitialArg = __EXPERIMENTAL__; +export const enableUseDeferredValueInitialArg = false; export const enableUseEffectEventHook = false; export const enableUseMemoCacheHook = true; export const favorSafetyOverHydrationPerf = true;