diff --git a/compiler/packages/babel-plugin-react-compiler/src/ReactiveScopes/CodegenReactiveFunction.ts b/compiler/packages/babel-plugin-react-compiler/src/ReactiveScopes/CodegenReactiveFunction.ts index 38d030cd7103c..ff11c09939aca 100644 --- a/compiler/packages/babel-plugin-react-compiler/src/ReactiveScopes/CodegenReactiveFunction.ts +++ b/compiler/packages/babel-plugin-react-compiler/src/ReactiveScopes/CodegenReactiveFunction.ts @@ -2206,7 +2206,7 @@ function codegenInstructionValue( * https://en.wikipedia.org/wiki/List_of_Unicode_characters#Control_codes */ const STRING_REQUIRES_EXPR_CONTAINER_PATTERN = - /[\u{0000}-\u{001F}|\u{007F}|\u{0080}-\u{FFFF}]|"/u; + /[\u{0000}-\u{001F}\u{007F}\u{0080}-\u{FFFF}]|"/u; function codegenJsxAttribute( cx: Context, attribute: JsxAttribute diff --git a/compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/fbt/fbt-params.expect.md b/compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/fbt/fbt-params.expect.md index d5ec6eb4687f9..c15244491fd21 100644 --- a/compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/fbt/fbt-params.expect.md +++ b/compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/fbt/fbt-params.expect.md @@ -6,9 +6,14 @@ import fbt from "fbt"; function Component(props) { return ( - - Hello {props.name} - +
+ + Hello {props.name} + + + {props.actions} + +
); } @@ -27,7 +32,7 @@ import { c as _c } from "react/compiler-runtime"; import fbt from "fbt"; function Component(props) { - const $ = _c(2); + const $ = _c(7); let t0; if ($[0] !== props.name) { t0 = fbt._("Hello {user name}", [fbt._param("user name", props.name)], { @@ -38,7 +43,33 @@ function Component(props) { } else { t0 = $[1]; } - return t0; + let t1; + if ($[2] !== props.actions) { + t1 = fbt._( + "{actions|response}", + [fbt._param("actions|response", props.actions)], + { hk: "1cjfbg" }, + ); + $[2] = props.actions; + $[3] = t1; + } else { + t1 = $[3]; + } + let t2; + if ($[4] !== t0 || $[5] !== t1) { + t2 = ( +
+ {t0} + {t1} +
+ ); + $[4] = t0; + $[5] = t1; + $[6] = t2; + } else { + t2 = $[6]; + } + return t2; } export const FIXTURE_ENTRYPOINT = { diff --git a/compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/fbt/fbt-params.js b/compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/fbt/fbt-params.js index b2959036e57b2..4750fcf8a7aa2 100644 --- a/compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/fbt/fbt-params.js +++ b/compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/fbt/fbt-params.js @@ -2,9 +2,14 @@ import fbt from "fbt"; function Component(props) { return ( - - Hello {props.name} - +
+ + Hello {props.name} + + + {props.actions} + +
); }