You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm testing running React through Closure optimizations (with ClojureScript), and I've hit problem where e.g. children property gets included in output when using renderToString/staticMarkup:
<p children="foo, ,bar,,1">foo bar1</p>
(the way children value is converted to string could be due to Cljs).
This is due to Google Closure removes all the properties from the RESERVED_PROPS objects, as they aren't statically accessed.
I'm testing running React through Closure optimizations (with ClojureScript), and I've hit problem where e.g.
children
property gets included in output when usingrenderToString/staticMarkup
:(the way children value is converted to string could be due to Cljs).
This is due to Google Closure removes all the properties from the
RESERVED_PROPS
objects, as they aren't statically accessed.@banga already has fix for ReactElement in #11967 / #11995:
7d50185
But React-dom server has another place with the same problem:
react/packages/react-dom/src/server/ReactPartialRenderer.js
Lines 312 to 317 in ad9544f
Unfortunately looks like this isn't fixable by externs or other means by user, so it would be nice to have this fixed here.
(Mostly React already works with Closure optimizations in Cljs, but my test-suite uses
renderToStaticMarkup
.)The text was updated successfully, but these errors were encountered: