Skip to content

Commit

Permalink
FIX(Graphql): Add support for input with default values (#4540)
Browse files Browse the repository at this point in the history 
Summary:
Hello here 👋

We have a few inputs with default required fields that have default values like here :

```graphql
input StoryPinInput {
  id: ID!
  isGlobal: Boolean! = false
}
```

but the TS generated for this look like
```ts
export type StoryPinInput = {
  id: string;
  isGlobal: boolean;
};
```
which is not ideal ...

so i marked the field as optional if it has a default :)

Pull Request resolved: #4540

Reviewed By: voideanvalue

Differential Revision: D52629725

Pulled By: captbaritone

fbshipit-source-id: 472a6fcda0862cf974f16d2bbfe6c401b5415544
  • Loading branch information
@eMerzh @facebook-github-bot
eMerzh authored and facebook-github-bot committed Jan 10, 2024
1 parent 0e963dd commit 1a57f08
Show file tree
Hide file tree
Showing 72 changed files with 262 additions and 169 deletions.
4 changes: 2 additions & 2 deletions compiler/crates/graphql-ir/tests/parse/fixtures/argument_definitions.expected
View file
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ fragment TestFragment on User
},
],
used_global_variables: [],
type_condition: Object(69),
type_condition: Object(70),
directives: [
Directive {
name: WithLocation {
Expand All @@ -87,7 +87,7 @@ fragment TestFragment on User
alias: None,
definition: WithLocation {
location: argument_definitions.graphql:161:171,
item: FieldID(516),
item: FieldID(518),
},
arguments: [],
directives: [],
Expand Down
4 changes: 2 additions & 2 deletions compiler/crates/graphql-ir/tests/parse/fixtures/directive-generic.expected
View file
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,14 @@ fragment TestFragment on User {
},
variable_definitions: [],
used_global_variables: [],
type_condition: Object(69),
type_condition: Object(70),
directives: [],
selections: [
ScalarField {
alias: None,
definition: WithLocation {
location: directive-generic.graphql:34:36,
item: FieldID(459),
item: FieldID(461),
},
arguments: [],
directives: [
Expand Down
12 changes: 6 additions & 6 deletions compiler/crates/graphql-ir/tests/parse/fixtures/directive-include.expected
View file
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ fragment Foo on User {
directives: [],
},
],
type_condition: Object(69),
type_condition: Object(70),
directives: [],
selections: [
Condition {
Expand All @@ -47,7 +47,7 @@ fragment Foo on User {
alias: None,
definition: WithLocation {
location: directive-include.graphql:34:36,
item: FieldID(459),
item: FieldID(461),
},
arguments: [],
directives: [],
Expand Down Expand Up @@ -75,15 +75,15 @@ fragment Foo on User {
selections: [
InlineFragment {
type_condition: Some(
Object(69),
Object(70),
),
directives: [],
selections: [
ScalarField {
alias: None,
definition: WithLocation {
location: directive-include.graphql:97:106,
item: FieldID(456),
item: FieldID(458),
},
arguments: [],
directives: [],
Expand Down Expand Up @@ -154,14 +154,14 @@ fragment Foo on User {
},
variable_definitions: [],
used_global_variables: [],
type_condition: Object(69),
type_condition: Object(70),
directives: [],
selections: [
ScalarField {
alias: None,
definition: WithLocation {
location: directive-include.graphql:168:170,
item: FieldID(459),
item: FieldID(461),
},
arguments: [],
directives: [],
Expand Down
4 changes: 2 additions & 2 deletions compiler/crates/graphql-ir/tests/parse/fixtures/enum-values.expected
View file
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ query EnumValueQuery {
alias: None,
definition: WithLocation {
location: enum-values.graphql:34:48,
item: FieldID(473),
item: FieldID(475),
},
arguments: [
Argument {
Expand All @@ -60,7 +60,7 @@ query EnumValueQuery {
alias: None,
definition: WithLocation {
location: enum-values.graphql:72:75,
item: FieldID(179),
item: FieldID(181),
},
arguments: [],
directives: [],
Expand Down
4 changes: 2 additions & 2 deletions compiler/crates/graphql-ir/tests/parse/fixtures/field-arguments.expected
View file
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ query TestQuery {
alias: None,
definition: WithLocation {
location: field-arguments.graphql:89:107,
item: FieldID(513),
item: FieldID(515),
},
arguments: [],
directives: [],
Expand Down Expand Up @@ -144,7 +144,7 @@ query TestQuery {
alias: None,
definition: WithLocation {
location: field-arguments.graphql:164:169,
item: FieldID(54),
item: FieldID(55),
},
arguments: [],
directives: [],
Expand Down
2 changes: 1 addition & 1 deletion compiler/crates/graphql-ir/tests/parse/fixtures/fixme_fat_interface_on_union.expected
View file
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ query Test {
alias: None,
definition: WithLocation {
location: fixme_fat_interface_on_union.graphql:51:53,
item: FieldID(377),
item: FieldID(379),
},
arguments: [],
directives: [
Expand Down
14 changes: 7 additions & 7 deletions compiler/crates/graphql-ir/tests/parse/fixtures/fragment-with-arguments-syntax.expected
View file
Original file line number Diff line number Diff line change
Expand Up @@ -85,14 +85,14 @@ fragment Foo($localId: ID!) on User {
directives: [],
},
],
type_condition: Object(69),
type_condition: Object(70),
directives: [],
selections: [
LinkedField {
alias: None,
definition: WithLocation {
location: fragment-with-arguments-syntax.graphql:71:85,
item: FieldID(473),
item: FieldID(475),
},
arguments: [
Argument {
Expand Down Expand Up @@ -128,7 +128,7 @@ fragment Foo($localId: ID!) on User {
alias: None,
definition: WithLocation {
location: fragment-with-arguments-syntax.graphql:112:115,
item: FieldID(179),
item: FieldID(181),
},
arguments: [],
directives: [],
Expand All @@ -144,7 +144,7 @@ fragment Foo($localId: ID!) on User {
),
definition: WithLocation {
location: fragment-with-arguments-syntax.graphql:138:152,
item: FieldID(473),
item: FieldID(475),
},
arguments: [
Argument {
Expand Down Expand Up @@ -180,7 +180,7 @@ fragment Foo($localId: ID!) on User {
alias: None,
definition: WithLocation {
location: fragment-with-arguments-syntax.graphql:172:175,
item: FieldID(179),
item: FieldID(181),
},
arguments: [],
directives: [],
Expand Down Expand Up @@ -253,14 +253,14 @@ fragment Foo($localId: ID!) on User {
},
],
used_global_variables: [],
type_condition: Object(69),
type_condition: Object(70),
directives: [],
selections: [
ScalarField {
alias: None,
definition: WithLocation {
location: fragment-with-arguments-syntax.graphql:246:248,
item: FieldID(459),
item: FieldID(461),
},
arguments: [],
directives: [],
Expand Down
14 changes: 7 additions & 7 deletions compiler/crates/graphql-ir/tests/parse/fixtures/fragment-with-arguments.expected
View file
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ fragment Foo on User @argumentDefinitions(localId: {type: "ID!"}) {
directives: [],
},
],
type_condition: Object(69),
type_condition: Object(70),
directives: [
Directive {
name: WithLocation {
Expand All @@ -104,7 +104,7 @@ fragment Foo on User @argumentDefinitions(localId: {type: "ID!"}) {
alias: None,
definition: WithLocation {
location: fragment-with-arguments.graphql:131:145,
item: FieldID(473),
item: FieldID(475),
},
arguments: [
Argument {
Expand Down Expand Up @@ -140,7 +140,7 @@ fragment Foo on User @argumentDefinitions(localId: {type: "ID!"}) {
alias: None,
definition: WithLocation {
location: fragment-with-arguments.graphql:172:175,
item: FieldID(179),
item: FieldID(181),
},
arguments: [],
directives: [],
Expand All @@ -156,7 +156,7 @@ fragment Foo on User @argumentDefinitions(localId: {type: "ID!"}) {
),
definition: WithLocation {
location: fragment-with-arguments.graphql:198:212,
item: FieldID(473),
item: FieldID(475),
},
arguments: [
Argument {
Expand Down Expand Up @@ -192,7 +192,7 @@ fragment Foo on User @argumentDefinitions(localId: {type: "ID!"}) {
alias: None,
definition: WithLocation {
location: fragment-with-arguments.graphql:232:235,
item: FieldID(179),
item: FieldID(181),
},
arguments: [],
directives: [],
Expand Down Expand Up @@ -265,7 +265,7 @@ fragment Foo on User @argumentDefinitions(localId: {type: "ID!"}) {
},
],
used_global_variables: [],
type_condition: Object(69),
type_condition: Object(70),
directives: [
Directive {
name: WithLocation {
Expand All @@ -283,7 +283,7 @@ fragment Foo on User @argumentDefinitions(localId: {type: "ID!"}) {
alias: None,
definition: WithLocation {
location: fragment-with-arguments.graphql:347:349,
item: FieldID(459),
item: FieldID(461),
},
arguments: [],
directives: [],
Expand Down
8 changes: 4 additions & 4 deletions compiler/crates/graphql-ir/tests/parse/fixtures/fragment-with-literal-arguments.expected
View file
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ fragment ChildFragment on User
},
variable_definitions: [],
used_global_variables: [],
type_condition: Object(69),
type_condition: Object(70),
directives: [],
selections: [
FragmentSpread {
Expand Down Expand Up @@ -84,7 +84,7 @@ fragment ChildFragment on User
},
],
used_global_variables: [],
type_condition: Object(69),
type_condition: Object(70),
directives: [
Directive {
name: WithLocation {
Expand All @@ -102,7 +102,7 @@ fragment ChildFragment on User
alias: None,
definition: WithLocation {
location: fragment-with-literal-arguments.graphql:174:188,
item: FieldID(473),
item: FieldID(475),
},
arguments: [
Argument {
Expand Down Expand Up @@ -138,7 +138,7 @@ fragment ChildFragment on User
alias: None,
definition: WithLocation {
location: fragment-with-literal-arguments.graphql:215:218,
item: FieldID(179),
item: FieldID(181),
},
arguments: [],
directives: [],
Expand Down
12 changes: 6 additions & 6 deletions ...phql-ir/tests/parse/fixtures/fragment-with-literal-enum-arguments-into-enum-list.expected
View file
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ fragment ChildFragment on User
},
variable_definitions: [],
used_global_variables: [],
type_condition: Object(69),
type_condition: Object(70),
directives: [],
selections: [
LinkedField {
Expand All @@ -36,7 +36,7 @@ fragment ChildFragment on User
),
definition: WithLocation {
location: fragment-with-literal-enum-arguments-into-enum-list.graphql:53:61,
item: FieldID(450),
item: FieldID(452),
},
arguments: [
Argument {
Expand Down Expand Up @@ -66,7 +66,7 @@ fragment ChildFragment on User
alias: None,
definition: WithLocation {
location: fragment-with-literal-enum-arguments-into-enum-list.graphql:92:97,
item: FieldID(54),
item: FieldID(55),
},
arguments: [],
directives: [],
Expand Down Expand Up @@ -133,7 +133,7 @@ fragment ChildFragment on User
},
],
used_global_variables: [],
type_condition: Object(69),
type_condition: Object(70),
directives: [
Directive {
name: WithLocation {
Expand All @@ -151,7 +151,7 @@ fragment ChildFragment on User
alias: None,
definition: WithLocation {
location: fragment-with-literal-enum-arguments-into-enum-list.graphql:253:261,
item: FieldID(450),
item: FieldID(452),
},
arguments: [
Argument {
Expand Down Expand Up @@ -191,7 +191,7 @@ fragment ChildFragment on User
alias: None,
definition: WithLocation {
location: fragment-with-literal-enum-arguments-into-enum-list.graphql:297:302,
item: FieldID(54),
item: FieldID(55),
},
arguments: [],
directives: [],
Expand Down
4 changes: 2 additions & 2 deletions ...iler/crates/graphql-ir/tests/parse/fixtures/fragment-with-literal-enum-arguments.expected
View file
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ fragment ChildFragment on Query
alias: None,
definition: WithLocation {
location: fragment-with-literal-enum-arguments.graphql:90:98,
item: FieldID(512),
item: FieldID(514),
},
arguments: [],
directives: [],
Expand Down Expand Up @@ -177,7 +177,7 @@ fragment ChildFragment on Query
alias: None,
definition: WithLocation {
location: fragment-with-literal-enum-arguments.graphql:292:300,
item: FieldID(512),
item: FieldID(514),
},
arguments: [],
directives: [],
Expand Down
Loading

0 comments on commit 1a57f08

Please sign in to comment.