Typesafe Updaters with TypeScript language in compiler config cause compiler to panic

[captbaritone]

Ideally we could catch this and emit a diagnostic pointing to the use of the typesafe updater.

╭─[00:00]: captbaritone at moffo in ~/projects/relay-resolvers-todomvc on branch*
╰─➤ yarn relay
yarn run v1.22.18
warning ../package.json: No license field
$ relay-compiler
[INFO] querying files to compile...
[INFO] [default] compiling...
thread 'tokio-runtime-worker' panicked at 'Getters and setters with different types are not implemented in typescript. See https://github.com/microsoft/TypeScript/issues/43662', crates/relay-typegen/src/typescript.rs:240:21
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
[ERROR] A thread that the Relay compiler spun up did not shut down gracefully: panic
[ERROR] Compilation failed.
[ERROR] Unable to run relay compiler. Error details:
A thread that the Relay compiler spun up did not shut down gracefully: panic
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
╭─[00:00]: captbaritone at moffo in ~/projects/relay-resolvers-todomvc on branch*
╰─➤

[captbaritone]

cc @rbalicki2

[TJ09]

The listed blocker, microsoft/TypeScript#43662, is resolved as of TypeScript 5.1 (released in June, we're now on 5.2). I'm not sure if Relay has a process for requiring a specific minimum version of TS, but is it now theoretically possible to remove the compiler restriction and allow typesafe updaters on TypeScript?

[tobias-tengler]

I've already implemented it here: #4370
Just needs to be merged...

[ahmetuysal]

any idea on when this will be merged @tobias-tengler?

[tobias-tengler]

It's all ready to go from my side for a couple months now :) Someone on the Relay team like @captbaritone or @alunyov needs to review and merge it...

[tobias-tengler]

This can now be closed!