diff --git a/velox/exec/tests/SimpleArrayAggAggregate.cpp b/velox/exec/tests/SimpleArrayAggAggregate.cpp index 2f4fa3e80751..205fd6c70c1e 100644 --- a/velox/exec/tests/SimpleArrayAggAggregate.cpp +++ b/velox/exec/tests/SimpleArrayAggAggregate.cpp @@ -18,7 +18,7 @@ #include "velox/exec/SimpleAggregateAdapter.h" #include "velox/expression/FunctionSignature.h" #include "velox/expression/VectorWriters.h" -#include "velox/functions/prestosql/aggregates/ValueList.h" +#include "velox/functions/lib/aggregates/ValueList.h" using namespace facebook::velox::exec; diff --git a/velox/functions/lib/aggregates/CMakeLists.txt b/velox/functions/lib/aggregates/CMakeLists.txt index 1eabebce1f16..88d53af24bf6 100644 --- a/velox/functions/lib/aggregates/CMakeLists.txt +++ b/velox/functions/lib/aggregates/CMakeLists.txt @@ -15,7 +15,7 @@ add_library( velox_functions_aggregates AverageAggregateBase.cpp CentralMomentsAggregatesBase.cpp - SingleValueAccumulator.cpp ValueSet.cpp) + SingleValueAccumulator.cpp ValueList.cpp ValueSet.cpp) target_link_libraries(velox_functions_aggregates velox_exec velox_presto_serializer Folly::folly) diff --git a/velox/functions/prestosql/aggregates/ValueList.cpp b/velox/functions/lib/aggregates/ValueList.cpp similarity index 98% rename from velox/functions/prestosql/aggregates/ValueList.cpp rename to velox/functions/lib/aggregates/ValueList.cpp index f32fdebfb704..216d665287d0 100644 --- a/velox/functions/prestosql/aggregates/ValueList.cpp +++ b/velox/functions/lib/aggregates/ValueList.cpp @@ -13,7 +13,7 @@ * See the License for the specific language governing permissions and * limitations under the License. */ -#include "velox/functions/prestosql/aggregates/ValueList.h" +#include "velox/functions/lib/aggregates/ValueList.h" #include "velox/exec/ContainerRowSerde.h" namespace facebook::velox::aggregate { diff --git a/velox/functions/prestosql/aggregates/ValueList.h b/velox/functions/lib/aggregates/ValueList.h similarity index 100% rename from velox/functions/prestosql/aggregates/ValueList.h rename to velox/functions/lib/aggregates/ValueList.h diff --git a/velox/functions/lib/aggregates/tests/CMakeLists.txt b/velox/functions/lib/aggregates/tests/CMakeLists.txt index 3359a9a801a6..632ddef7f23d 100644 --- a/velox/functions/lib/aggregates/tests/CMakeLists.txt +++ b/velox/functions/lib/aggregates/tests/CMakeLists.txt @@ -13,3 +13,16 @@ # limitations under the License. add_subdirectory(utils) + +add_executable(velox_functions_aggregates_test ValueListTest.cpp) + +add_test(NAME velox_functions_aggregates_test COMMAND velox_functions_aggregates_test) + +target_link_libraries( + velox_functions_aggregates_test + velox_functions_aggregates + velox_functions_test_lib + Folly::folly + gtest + gtest_main + glog::glog) diff --git a/velox/functions/prestosql/aggregates/tests/ValueListTest.cpp b/velox/functions/lib/aggregates/tests/ValueListTest.cpp similarity index 97% rename from velox/functions/prestosql/aggregates/tests/ValueListTest.cpp rename to velox/functions/lib/aggregates/tests/ValueListTest.cpp index eee192944c83..59d1c061f6bc 100644 --- a/velox/functions/prestosql/aggregates/tests/ValueListTest.cpp +++ b/velox/functions/lib/aggregates/tests/ValueListTest.cpp @@ -13,10 +13,9 @@ * See the License for the specific language governing permissions and * limitations under the License. */ -#include "velox/functions/prestosql/aggregates/ValueList.h" #include +#include "velox/functions/lib/aggregates/ValueList.h" #include "velox/functions/prestosql/tests/utils/FunctionBaseTest.h" -#include "velox/vector/tests/utils/VectorMaker.h" using namespace facebook::velox; using namespace facebook::velox::test; diff --git a/velox/functions/prestosql/aggregates/ArrayAggAggregate.cpp b/velox/functions/prestosql/aggregates/ArrayAggAggregate.cpp index 35f2ff6d035e..7f05b71b9bf2 100644 --- a/velox/functions/prestosql/aggregates/ArrayAggAggregate.cpp +++ b/velox/functions/prestosql/aggregates/ArrayAggAggregate.cpp @@ -15,9 +15,8 @@ */ #include "velox/exec/ContainerRowSerde.h" #include "velox/expression/FunctionSignature.h" +#include "velox/functions/lib/aggregates/ValueList.h" #include "velox/functions/prestosql/aggregates/AggregateNames.h" -#include "velox/functions/prestosql/aggregates/ValueList.h" -#include "velox/vector/ComplexVector.h" namespace facebook::velox::aggregate::prestosql { namespace { diff --git a/velox/functions/prestosql/aggregates/CMakeLists.txt b/velox/functions/prestosql/aggregates/CMakeLists.txt index 20e0cdacfe76..d06ee83e93db 100644 --- a/velox/functions/prestosql/aggregates/CMakeLists.txt +++ b/velox/functions/prestosql/aggregates/CMakeLists.txt @@ -45,7 +45,6 @@ add_library( SetAggregates.cpp SumAggregate.cpp SumDataSizeForStatsAggregate.cpp - ValueList.cpp VarianceAggregates.cpp) target_link_libraries( diff --git a/velox/functions/prestosql/aggregates/MapAccumulator.h b/velox/functions/prestosql/aggregates/MapAccumulator.h index da073a02f721..3012c3ef04f7 100644 --- a/velox/functions/prestosql/aggregates/MapAccumulator.h +++ b/velox/functions/prestosql/aggregates/MapAccumulator.h @@ -19,7 +19,7 @@ #include "velox/common/memory/HashStringAllocator.h" #include "velox/exec/AddressableNonNullValueList.h" #include "velox/exec/Strings.h" -#include "velox/functions/prestosql/aggregates/ValueList.h" +#include "velox/functions/lib/aggregates/ValueList.h" #include "velox/vector/ComplexVector.h" #include "velox/vector/DecodedVector.h" #include "velox/vector/FlatVector.h" diff --git a/velox/functions/prestosql/aggregates/MultiMapAggAggregate.cpp b/velox/functions/prestosql/aggregates/MultiMapAggAggregate.cpp index 6a7da90515e6..5846f2d71320 100644 --- a/velox/functions/prestosql/aggregates/MultiMapAggAggregate.cpp +++ b/velox/functions/prestosql/aggregates/MultiMapAggAggregate.cpp @@ -16,8 +16,8 @@ #include "velox/exec/AddressableNonNullValueList.h" #include "velox/exec/Aggregate.h" #include "velox/exec/Strings.h" +#include "velox/functions/lib/aggregates/ValueList.h" #include "velox/functions/prestosql/aggregates/AggregateNames.h" -#include "velox/functions/prestosql/aggregates/ValueList.h" #include "velox/vector/FlatVector.h" namespace facebook::velox::aggregate::prestosql { diff --git a/velox/functions/prestosql/aggregates/tests/CMakeLists.txt b/velox/functions/prestosql/aggregates/tests/CMakeLists.txt index 3c1693c83b70..1ef8c99a8d7a 100644 --- a/velox/functions/prestosql/aggregates/tests/CMakeLists.txt +++ b/velox/functions/prestosql/aggregates/tests/CMakeLists.txt @@ -47,7 +47,6 @@ add_executable( SetUnionTest.cpp SumDataSizeForStatsTest.cpp SumTest.cpp - ValueListTest.cpp VarianceAggregationTest.cpp) add_test(