Release request: Could we get an updated release that builds on MacOS?

[sarahec]

Summary

I'm a maintainer over at NixOS and we have many packages that depend on faiss (directly or indirectly) , but are all broken on Darwin. I've tried to cherry-pick patches to no avail. Would you be able to release a point release that works on Darwin? That would enable support for hundreds of packages.

[mengdilin]

@sarahec which version of faiss are you on and is this for OSX x86_64 for OSX arm64? We release to conda forge every night for OSX arm64 (e.g. https://anaconda.org/pytorch/faiss-cpu)

[sarahec]

We are on release 1.8.0 (see nixpkgs search) and build for linux-{x86,arm64} and OSX (Darwin)-{x86,aarch64} whenever possible.

We're currently building from source and that's our preferred way. Also, we prefer published source releases, which is why we're back on 1.8.0.

I understand the testing and other work that goes into making a release, so my request may be a long shot. I had to try.

P.S. The main blocker seems to be the issue compiling swig-generated code due to the lack of SWIGTYPE_p_long and SWIGTYPE_p_unsigned_long while building the Python wrapper on MacOS. If there's a way to patch the code so it works again, we could patch out the bug while waiting for next versions of swig and/or faiss. (This also may be related to using swig 4.2.1)

[mengdilin]

Is the x86 version failing or faiss compilation is failing for both?

We have working nightly releases for OSX arm64 that runs on macOS 14 off of the main branch and part of that release compiles faiss from source and runs all of the relevent python tests along with it. Can you try compiling with the latest code on master and see if it works? If so, I can talk to the team about cutting a release.

[sarahec]

It's fine on x86, and breaking on macos. I'll try with the latest code on master and report back (thank you!).

[sarahec]

Yes, building from master works on both OSX and Linux.

[mengdilin]

We should be doing a release next week :) Will keep you updated

[sarahec]

You are amazing. Thank you.

[github-actions]

This issue is stale because it has been open for 7 days with no activity.

[sarahec]

The work is still in progress, my silicon friend. Awaiting the next release.

[sarahec]

How is the release coming along, if I might ask? (We're starting the release cycle for 24.11 and it would be lovely if we could include this.)

[asadoughi]

I am working on the release this week in #3887

[sarahec]

Thank you!!