Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a .gitignore #42

Closed
rijkvanzanten opened this issue Aug 12, 2024 · 2 comments · Fixed by #44
Closed

Add a .gitignore #42

rijkvanzanten opened this issue Aug 12, 2024 · 2 comments · Fixed by #44

Comments

@rijkvanzanten
Copy link
Contributor

I don't believe .DS_Store, node_modules, nor .vscode are intended to be in the main branch of the repo, but correct me if I'm wrong!

Happy to open a PR to resolve if wanted.

@chadwhitacre
Copy link
Contributor

Oops! Agreed, let's clean that up. A PR would be great @rijkvanzanten, thanks. :)

I did find this advice re: .vscode. Seem reasonable?

@rijkvanzanten
Copy link
Contributor Author

I did find this advice re: .vscode. Seem reasonable?

IMO If important build steps or configuration is stored in .vscode settings specifically, it means you're alienating folks who don't use vs code 🤔 That being said, you could also view it from the other side and say that we're progressively enhancing the DX for people using vs code. There's also a potential conflict where personal preferences bleed out to the rest of the team (f.e. if I set the project-settings to tabs instead of spaces).

Either way I'll include the recommended gitignore for the vscode settings 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants