Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor repository #15

Closed
ffgiraldez opened this issue Apr 14, 2018 · 0 comments · Fixed by #21
Closed

Refactor repository #15

ffgiraldez opened this issue Apr 14, 2018 · 0 comments · Fixed by #21
Assignees
@ffgiraldez

Comments

@ffgiraldez
Copy link
Owner

Repository actually use API and Database implementation details, create some data source and abstract access to them.
@ffgiraldez ffgiraldez self-assigned this Apr 21, 2018
ffgiraldez added a commit that referenced this issue May 6, 2018
@ffgiraldez
feat: extract common data logic
e21c23e 
create ComicLocalDataSource & ComicRemoteDataSource polymorphic on T
refactor ComicRepository to use ComicLocalDataSource & ComicRemoteDataSource and polymorphic on T
create specific datasources & repository for Suggestion
create specific datasources & repository for Search

reorganise packages to reflect data common feature.

closes #15
@ffgiraldez ffgiraldez mentioned this issue May 6, 2018
Merged
ffgiraldez added a commit that referenced this issue May 6, 2018
@ffgiraldez
feat: extract common data logic (#21)
1d22681 
create ComicLocalDataSource & ComicRemoteDataSource polymorphic on T
refactor ComicRepository to use ComicLocalDataSource & ComicRemoteDataSource and polymorphic on T
create specific datasources & repository for Suggestion
create specific datasources & repository for Search

reorganise packages to reflect data common feature.

closes #15
ffgiraldez added a commit that referenced this issue May 6, 2018
@ffgiraldez
feat: 🏗️ extract common data logic (#21)
3d3bdf0 
create ComicLocalDataSource & ComicRemoteDataSource polymorphic on T
refactor ComicRepository to use ComicLocalDataSource & ComicRemoteDataSource and polymorphic on T
create specific datasources & repository for Suggestion
create specific datasources & repository for Search

reorganise packages to reflect data common feature.

closes #15
@ffgiraldez ffgiraldez mentioned this issue Oct 2, 2020
Merged
ffgiraldez added a commit that referenced this issue Oct 2, 2020
@ffgiraldez
feat: 🔥 rx-java and 🔀 to kotlinx-coroutines (#33)
5a0977b 
resolves #15 resolves #31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ffgiraldez ffgiraldez

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: extract common data logic ffgiraldez/reactive-mvvm-android
1 participant
@ffgiraldez