Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CpuInfoProvider might return different values #38

Closed
NeacsuCristian opened this issue Aug 30, 2021 · 5 comments · Fixed by #59
Closed

CpuInfoProvider might return different values #38

NeacsuCristian opened this issue Aug 30, 2021 · 5 comments · Fixed by #59

Comments

@NeacsuCristian
Copy link

Hello,

I am trying to figure it out what is happening with different fingerprints on different running.
The main issue is that I found in CpuInfoProvider that reading /proc/cpuinfo multiple times, returns different values of BogoMIPS, therefore it will return different fingerprints.

For exemple reading /proc/cpuinfo at one run:
2021-08-31 00:59:15.463 15908-15938/eco.eep I/System.out: HERE: processor : 0
2021-08-31 00:59:15.465 15908-15938/eco.eep I/System.out: HERE: BogoMIPS : 33.17
2021-08-31 00:59:15.475 15908-15938/eco.eep I/System.out: HERE: processor : 1
2021-08-31 00:59:15.478 15908-15938/eco.eep I/System.out: HERE: BogoMIPS : 33.17
2021-08-31 00:59:15.482 15908-15938/eco.eep I/System.out: HERE: processor : 2
2021-08-31 00:59:15.483 15908-15938/eco.eep I/System.out: HERE: BogoMIPS : 26.08
2021-08-31 00:59:15.491 15908-15938/eco.eep I/System.out: HERE: processor : 3
2021-08-31 00:59:15.494 15908-15938/eco.eep I/System.out: HERE: BogoMIPS : 26.08

at second run:
2021-08-31 00:59:30.990 15994-16031/eco.eep I/System.out: HERE: c3e0428bf5fbd27f15932e800e87922a
2021-08-31 00:59:31.002 15994-16031/eco.eep I/System.out: HERE: processor : 0
2021-08-31 00:59:31.004 15994-16031/eco.eep I/System.out: HERE: BogoMIPS : 33.17
2021-08-31 00:59:31.009 15994-16031/eco.eep I/System.out: HERE: processor : 1
2021-08-31 00:59:31.010 15994-16031/eco.eep I/System.out: HERE: BogoMIPS : 33.17
2021-08-31 00:59:31.014 15994-16031/eco.eep I/System.out: HERE: processor : 2
2021-08-31 00:59:31.015 15994-16031/eco.eep I/System.out: HERE: BogoMIPS : 33.17
2021-08-31 00:59:31.021 15994-16031/eco.eep I/System.out: HERE: processor : 3
2021-08-31 00:59:31.024 15994-16031/eco.eep I/System.out: HERE: BogoMIPS : 33.17

at 3rd run:
2021-08-31 00:59:52.482 16083-16120/eco.eep I/System.out: HERE: processor : 0
2021-08-31 00:59:52.484 16083-16120/eco.eep I/System.out: HERE: BogoMIPS : 33.17
2021-08-31 00:59:52.488 16083-16120/eco.eep I/System.out: HERE: processor : 1
2021-08-31 00:59:52.489 16083-16120/eco.eep I/System.out: HERE: BogoMIPS : 26.08
2021-08-31 00:59:52.493 16083-16120/eco.eep I/System.out: HERE: processor : 2
2021-08-31 00:59:52.495 16083-16120/eco.eep I/System.out: HERE: BogoMIPS : 26.08
2021-08-31 00:59:52.500 16083-16120/eco.eep I/System.out: HERE: processor : 3
2021-08-31 00:59:52.503 16083-16120/eco.eep I/System.out: HERE: BogoMIPS : 26.08

Therefore the BogoMIPS in my case can be either 33.17 or 26.08, therefore the output of fingerprint will differ. Am I doing something wrong?

@Alexey-Verkhovsky
Copy link
Member

Alexey-Verkhovsky commented Sep 1, 2021

Hello! 👋
Thanks for the report. You are doing everything right.
Looks like we need to improve this signal. Can you tell me what a device you are using?

@NeacsuCristian
Copy link
Author

NeacsuCristian commented Sep 1, 2021

Hello

The device is an Lenovo Tab M7 tablet.
https://www.amazon.com/Lenovo-Quad-Core-Processor-Bluetooth-ZA55012US/dp/B084GZTYMW/ref=sr_1_3?dchild=1&keywords=lenovo+tab+m7&qid=1630515633&sr=8-3

I tried as well on Lenovo Tab M8 and it seems to work, but again I do not have a multitude of devices that I could try. But what I can guarantee is that /proc/cpuinfo on M7 is returning different results, and might be dangerous.

@Alexey-Verkhovsky
Copy link
Member

Yes, it seems we need to choose more stable lines for STABLE fingerprint. Thanks again for the report. I'll close the issue when fixes are ready!

@Sergey-Makarov
Copy link
Contributor

Reopened after automatic close. Will close it when the next release is ready.

@Sergey-Makarov
Copy link
Contributor

Fixed in release 1.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants