Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

[Windows] Ctrl+P .highlight markers font looks blurry on Windows #5584

Closed
jnachtigall opened this issue Mar 2, 2018 · 6 comments
Closed
Assignees
Labels

Comments

@jnachtigall
Copy link
Contributor

I noticed this since a 3, 4 weeks. The highlighted, bold parts of the Search matches of Ctrl+P look blurry on Windows. No idea why, maybe some odd fonts settings. I also captured the browser.xul output, but cannot see anything obvious in the CSS:

image

See how bold, kinda ugly the bold api match looks. The letter spacing is kind of too narrow.

I looked at this also on Linux and there it looks fine.

PS Looking at the source I see that the match is hightlighted using <strong class="hightlight">. While this is not totally incorrect afaik, I think it should rather be <mark> to make it semantically 100% correct and better accessibly. By the way there's also https://github.com/bvaughn/react-highlight-words (which also uses mark not strong here).

@lukaszsobek
Copy link
Contributor

/claim

@claim
Copy link

claim bot commented Mar 3, 2018

Thanks for claiming the issue! 👋

Here are some links for getting setup, contributing, and developing. We're always happy to answer questions in slack! If you become busy, feel free to /unclaim it.

🦊 Debugger team!

@lukaszsobek
Copy link
Contributor

@jasonLaster I read up on the code and fuzzy-aldrin-plus uses strong internally. Technically it should accept options as its third parameter in which we are then able to set the way it highlights, but this options object seems to be completely ignored. Referring the issue: jeancroy/fuzz-aldrin-plus#37

@jasonLaster
Copy link
Contributor

Thanks, lets see what they say

@lukaszsobek
Copy link
Contributor

Merged. Closing.

@jnachtigall
Copy link
Contributor Author

@lukaszsobek It still (or again) looks blurry on Nightly:

image

For instance, check the 4th entry PathUtils.js letters. So using <mark> instead of <strong> did not seem to have fixed the issue. I am on Windows 10.

Can you reopen?

PS Looks like the

.result-item .title .highlight {

    font-weight: bold;
}

causes this. I am not a fonts expert, but maybe the used font on Windows is not great for bold.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants