Navigating callstack conflicts with search result focussing

[digitarald]

STR:

• Open Debugger on https://bl.ocks.org/ColinEberhardt/raw/6ceb7ca74aabac9c8534d7120d31b382/
• Open JS file
• Search for wasm.
• Pause and step until it hits WASM code (look for wasm2 methods)
• Step between WASM code and JS in callstack

25% speed:

[janodvarko]

I can nicely reproduce this issue.

Note that the issue happens only when the user switches from WASM file to JS file. I.e. instead of navigating to the (clicked) frame location in the JS file the current search location is selected. When the users switches between to JS frames it works well.

Honza

[tanhengyeow]

Is this a good issue for newbies to contribute? :)

If so, any tips on where to dig into?

[darkwing]

This could be a bit tough; you may want to look at the "help wanted" and "good first issue" labels 👍

[navgurukul-shivani18]

I tried but not getting how to lead to it and, couldn't find a way to solve it. Can someone help me please?

[AnshulMalik]

Don't be disappointed @navgurukul-shivani18. This issue is a bit tough to start with. You might want to take on something not so tough.

[navgurukul-shivani18]

@AnshulMalik Can you please help me finding any good bug to work on? Please!

[YisraelV]

/claim

Hope it's not too hard. I'll try my luck!

[claim]

Thanks for claiming the issue! 👋

Here are some links for getting setup, contributing, and developing. We're always happy to answer questions in slack! If you become busy, feel free to /unclaim it.

🦊 Debugger team!

[YisraelV]

Copying from slack:

currently if there is some text in the search box, and user navigates between files, the search results are updated and the document is scrolled to the first result.

This issue is about when the user navigates using the stack-frames panel. The expected behavior is scrolling to the executed line, but the actual behavior is scrolling to the first search result.

In my opinion this is a more general problem: when the user navigates to a file it should always start at the first line, regardless if it's with quick-open, clicking on tab or selecting a stack-frame. The user probably just wanted to see the file and there is no reason to scroll to the first result.

I checked the behavior of two other code editors:

1. in vscode when navigating to a file the search results are updated, but the scroll-to-first-result is not triggered.
2. Chrome devtools only shows a message "n results" (e.g. "5 results")" but without scrolling and without showing the current result message (e.g. 2 out of 4) only when the user retriggers the search (by pressing enter inside the search bar) the first result is selected and scroll to.

I find Chrome's to be the best user experience. Please tell me what you think, and if others agree with me I will try to implement it in the code.

Thanks for your help!

[jasonLaster]

I agree @YisraelV. Chrome's approach is nice

[darkwing]

Just landed fix in MC.