Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

Search field polish #7425

Closed
violasong opened this issue Dec 5, 2018 · 10 comments
Closed

Search field polish #7425

violasong opened this issue Dec 5, 2018 · 10 comments
Labels
👋 good first issue 👋 polish Improving a feature that isn't broken

Comments

@violasong
Copy link

violasong commented Dec 5, 2018

Find in File:

Pretty print/blackbox buttons, modifier buttons, and x button should have the same background hover highlight as other buttons in devtools.

(Same for all other buttons in Debugger, but most of them at least have a subtle highlight. Especially in need of an update are pretty print/blackbox (overlaps at the top) and any buttons in dark mode (too subtle))

Quick Open:

In dark mode, the light shadow seems odd - could we try a black shadow instead?

Find in project:

Discussion point - do we still want to move it to the bottom and style like Find in File? https://mozilla.invisionapp.com/share/Y8H6UH8V5HX#/screens

cc @mcroud

@darkwing
Copy link
Contributor

Pretty print/blackbox buttons, modifier buttons, and x button should have the same background hover highlight as other buttons in devtools.

What color is that?

@darkwing darkwing added 👋 polish Improving a feature that isn't broken 👋 good first issue labels Dec 10, 2018
@rjairath
Copy link

Hi,
I would like to work on this issue

@darkwing
Copy link
Contributor

Sounds good @rjairath ! I can't wait to see what you come up with!

@violasong
Copy link
Author

What color is that?

Oh haha, great question - I realized it's currently pretty inconsistent across DevTools. I just really noticed it in Debugger because the pretty print has that overlapping problem, and the stepper icons have a non-photon blue-ish hover.

I think we should change all button hover backgrounds to match the more contrasted gray color of the top-level tab highlight. We can do that for Debugger in this bug, and I'll also file a bugzilla for the rest of DevTools.

@violasong
Copy link
Author

Overall DevTools bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1513414

@rjairath
Copy link

/claim

@claim
Copy link

claim bot commented Dec 12, 2018

Thanks for claiming the issue! 👋

!!! Please check your email and confirm the invitation

Here are some links for getting setup, contributing, and developing. We're always happy to answer questions in slack! If you become busy, feel free to /unclaim it.

🦊 Debugger team!

@rjairath
Copy link

rjairath commented Jan 4, 2019

firefoxbug

@rjairath
Copy link

rjairath commented Jan 4, 2019

So in the 2 buttons pointed above I have to change the :hover class property as the one in all other buttons. Can you please tell me the css file where I have to make this change.

@darkwing darkwing mentioned this issue Jan 7, 2019
25 tasks
@rjairath
Copy link

rjairath commented Feb 6, 2019

/unclaim

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
👋 good first issue 👋 polish Improving a feature that isn't broken
Projects
None yet
Development

No branches or pull requests

3 participants