From be0abe4de90029a870edd32fe4d978ccdc1af3d7 Mon Sep 17 00:00:00 2001 From: Harshal Lele Date: Mon, 11 Feb 2019 21:24:11 +0530 Subject: [PATCH 01/10] moved arrow icon to outside the label --- .../SecondaryPanes/EventListeners.js | 24 +++++++++---------- 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/src/components/SecondaryPanes/EventListeners.js b/src/components/SecondaryPanes/EventListeners.js index 3ab1b7ef57..4504fcc1d8 100644 --- a/src/components/SecondaryPanes/EventListeners.js +++ b/src/components/SecondaryPanes/EventListeners.js @@ -46,8 +46,6 @@ class EventListeners extends Component { } onCategoryToggle(category, event) { - event.preventDefault(); - const { expandedCategories } = this.state; if (expandedCategories.includes(category)) { @@ -102,20 +100,22 @@ class EventListeners extends Component { ); return ( - ); From 5a090f1edae08ebc4018d42a6cab56fbe7186f32 Mon Sep 17 00:00:00 2001 From: Harshal Lele Date: Tue, 12 Feb 2019 19:23:41 +0530 Subject: [PATCH 04/10] fixed formatting --- src/components/SecondaryPanes/EventListeners.css | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/components/SecondaryPanes/EventListeners.css b/src/components/SecondaryPanes/EventListeners.css index 5412a6fccc..276d0533de 100644 --- a/src/components/SecondaryPanes/EventListeners.css +++ b/src/components/SecondaryPanes/EventListeners.css @@ -26,12 +26,12 @@ } .event-listener-group label { - display:flex; + display: flex; align-items: center; } .event-listener-category { - padding:3px 0px; + padding: 3px 0px; line-height: 14px; } @@ -62,5 +62,5 @@ html[dir="rtl"] .event-listeners-content .arrow.expanded { margin-inline-end: 4px; margin-inline-start: 0px; margin-top: 0px; - margin-bottom: 0px; + margin-bottom: 0px; } From bf021285701b86053e591f2fe201c84d87344be6 Mon Sep 17 00:00:00 2001 From: Harshal Lele Date: Wed, 13 Feb 2019 11:54:36 +0530 Subject: [PATCH 05/10] wrapped button around the arrow --- src/components/SecondaryPanes/EventListeners.css | 9 ++++++++- src/components/SecondaryPanes/EventListeners.js | 10 ++++++---- 2 files changed, 14 insertions(+), 5 deletions(-) diff --git a/src/components/SecondaryPanes/EventListeners.css b/src/components/SecondaryPanes/EventListeners.css index 276d0533de..5d00f925eb 100644 --- a/src/components/SecondaryPanes/EventListeners.css +++ b/src/components/SecondaryPanes/EventListeners.css @@ -15,11 +15,18 @@ user-select: none; } -.event-listener-group div { +.event-listener-header { display: flex; align-items: center; } +.btn-expand-category { + border: none; + background: none; + padding: 4px 5px; + line-height: 12px; +} + .event-listener-group input[type="checkbox"] { margin-top: 0px; margin-bottom: 0px; diff --git a/src/components/SecondaryPanes/EventListeners.js b/src/components/SecondaryPanes/EventListeners.js index 0247e8f97d..c983f30faa 100644 --- a/src/components/SecondaryPanes/EventListeners.js +++ b/src/components/SecondaryPanes/EventListeners.js @@ -100,11 +100,13 @@ class EventListeners extends Component { ); return ( -
- +