Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove memo padding during coin identification #1380

Closed
AaronFeickert opened this issue Dec 18, 2023 · 0 comments · Fixed by #1381
Closed

Remove memo padding during coin identification #1380

AaronFeickert opened this issue Dec 18, 2023 · 0 comments · Fixed by #1381

Comments

@AaronFeickert
Copy link
Contributor

Spark transactions include an encrypted memo. To reduce metadata, the memo is padded to a fixed length before encryption. This is somewhat subpar, as the padding is not removed.

A straightforward way to improve the user experience and avoid confusion would be to prepend the memo length before padding, and include this length in the encrypted data.

@AaronFeickert AaronFeickert changed the title Consider an encrypted memo length flag Remove memo padding during coin identification Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant