Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functions to deprecate/remove #65

Closed
12 of 13 tasks
droglenc opened this issue Jan 16, 2021 · 1 comment
Closed
12 of 13 tasks

Functions to deprecate/remove #65

droglenc opened this issue Jan 16, 2021 · 1 comment

Comments

@droglenc
Copy link
Contributor

droglenc commented Jan 16, 2021

We should consider removing the following functions as they are only peripherally related to the purpose of FSA and cause some maintenance or performance issues. For some of these we could create a vignette (or the like) that demonstrates how this functionality is better performed with functions from other packages.

  • bootcase et al. ... was added because bootCase() was replaced in car with Boot(). Possibly keep confint.bootCase() etc but changed to confint.Boot(), etc.
  • chooseColors() and palletteChoices() ... these should be updated ... there is much more info on properly choosing colors now than I was aware of when I wrote these. These should probably not be exported (i.e., should be treated as internal functions) as there are much better packages for handling colors.
  • compIntercepts() ... this can be replaced with emmeans() in emmeans package. This does NOT appear in IFAR.
  • compSlopes() ... this can be replaced with emtrends() in emmeans package. This does NOT appear in IFAR.
  • diag() ... this is not used by any other functions ... can just be removed (i.e., moved to FSAmisc).
  • filterD() ... I used this for teaching (automatically drops unused factor levels after filtering) ... probably not something we ultimately want to maintain.
  • fitPlot() ... this was largely added for teaching purposes ... might be better to teach students how to make these plots manually so that they can transfer that skill to methods not supported by fitPlot(). This does NOT appear in IFAR.
  • hoCoef() ... I added this only for the purpose of testing that b=3 in a W-L regression ... not sure it has any greater purpose.
  • mapvalues() ... could just teach students to use plyr::mapvalues() rather than re-exporting it here ... this is not used in any function in FSA ... will need to write an errata for IFAR ... this may allow removing plyr Imports
  • plotBinResp() ... I added this for a logistic regression example in my stats class ... pretty hacky ... probably better handled in a more manual way ... this is used in fitPlot() for logistic regressions.
  • residPlot() ... same idea as fitPlot() ... this WILL require an errata for IFAR.
  • Subset() ... has been deprecated for years ... should finally remove
  • Summarize() ... another one I made for teaching ... probably better to teach group_by() with summarize()???
@droglenc
Copy link
Contributor Author

Summarize() is used in several other functions in FSA, is used in several tests, may generally be a useful quick summary to users (similar to peek()), and provides some functionality not readily available in base R (e.g., number of valid observations). Mostly to minimize possible breaking changes to other functions I suggest we do NOT deprecate Summarize().

@droglenc droglenc closed this as completed Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants