Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wrong polynomial coefficients in cQuarticPoly.m #5

Closed
KexianShen opened this issue Mar 30, 2020 · 2 comments
Closed

wrong polynomial coefficients in cQuarticPoly.m #5

KexianShen opened this issue Mar 30, 2020 · 2 comments

Comments

@KexianShen
Copy link
Contributor

KexianShen commented Mar 30, 2020 •
edited
Loading

Some polynomial coefficients are wrong in cQuarticPoly.m.

It should be:

line 30: x = obj.c(2) + 2 * obj.c(3).*t + 3 * obj.c(4).*t.^2 + 4 * obj.c(5).*t.^3;

line 34: x = 2 * obj.c(3) + 6 * obj.c(4).*t + 12 * obj.c(5).*t.^2;
@fjp
Copy link
Owner

fjp commented Mar 30, 2020

Nice catch @KexianShen and thank you for opening a new issue.

You are also welcome to make a pull request. Otherwise, I'll fix this mistake by the end of this week.

Thanks again for your contribution.

@KexianShen
Copy link
Contributor Author

You are welcome, I have made a pull request, please check that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fjp @KexianShen