Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No longer any default direction or locale #1772

Closed
clarkwinkelmann opened this issue Apr 14, 2019 · 1 comment · Fixed by #1860
Closed

No longer any default direction or locale #1772

clarkwinkelmann opened this issue Apr 14, 2019 · 1 comment · Fixed by #1860
Labels
Good first issue type/regression
Milestone
0.1.0-beta.10

Comments

@clarkwinkelmann
Copy link
Member

clarkwinkelmann commented Apr 14, 2019 •
edited
Loading

Bug Report

Current Behavior
Any beta 8 or dev-master forum has <html dir="" lang=""> at the top of the document.

Steps to Reproduce

  1. Look at source HTML of any forum

Expected Behavior
The values should not be empty

Environment

  • Flarum version: beta8, dev-master

Possible Solution
The default values were removed in #1471

The default values were previously defined here in FrontendView https://github.com/flarum/core/pull/1471/files#diff-17e7b99805890a6754d57096b8dfbc9bL295 and before that it was WebAppView when it was added #1105

There is no longer any default value since https://github.com/flarum/core/blob/9115b9e28f9c5d1b53708090f183d71e095678ce/src/Frontend/Document.php#L164

We either need to force language packs (including english) to use those methods, or define default values again for the current language and direction as ltr.

Additional Context
Investigated after https://discuss.flarum.org/d/19701-w3c-xhtml-validation-service-flarum-error
@clarkwinkelmann
Copy link
Member Author

Updated: I didn't correctly check dev-master. I realize that exact issue isn't present in dev-master after #1677 . Though I think adding default values back instead of removing them would be a better solution

@franzliedke franzliedke added this to the 0.1.0-beta.10 milestone Aug 16, 2019
@dsevillamartin dsevillamartin mentioned this issue Aug 26, 2019
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good first issue type/regression
Projects
None yet
Milestone
0.1.0-beta.10
Development

Successfully merging a pull request may close this issue.

Add back defaults for language and direction attributes flarum/framework
2 participants
@franzliedke @clarkwinkelmann