Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

post number changes on page refresh #789

Closed
sijad opened this issue Feb 10, 2016 · 3 comments · Fixed by #2476
Closed

post number changes on page refresh #789

sijad opened this issue Feb 10, 2016 · 3 comments · Fixed by #2476

Comments

@sijad
Copy link
Contributor

sijad commented Feb 10, 2016

with each refreshing discuss page, the post number changes to previous post

for example if you're at localhost/flarum/d/{discuss-title}/20
with each refreshing it goes to localhost/flarum/d/{discuss-title}/19, localhost/flarum/d/{discuss-title}/18, and so-on

@axadr
Copy link

axadr commented Feb 20, 2016

It is because of after scrollToNumber(near) calculatePosition gets startNumber = near - 1

I think we should pass near to positionChanged event.

@franzliedke franzliedke modified the milestone: 0.1.0 Apr 7, 2016
@tobyzerner tobyzerner removed this from the 0.1.0 milestone Jul 22, 2017
@askvortsov1
Copy link
Sponsor Member

Fixed in #2160

@askvortsov1 askvortsov1 added this to the 0.1.0-beta.14 milestone Oct 2, 2020
@askvortsov1
Copy link
Sponsor Member

Unfortunately not yet fully fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants