From 5575bfabcac67048f8cea073c38acb0c093af361 Mon Sep 17 00:00:00 2001 From: Fransiscus Rolanda Malau Date: Fri, 1 Oct 2021 20:02:40 +0700 Subject: [PATCH 1/3] Add missing autocomplete attributes to input fields --- js/src/forum/components/LogInModal.js | 1 + 1 file changed, 1 insertion(+) diff --git a/js/src/forum/components/LogInModal.js b/js/src/forum/components/LogInModal.js index 70445a1715..427aa8fae1 100644 --- a/js/src/forum/components/LogInModal.js +++ b/js/src/forum/components/LogInModal.js @@ -83,6 +83,7 @@ export default class LogInModal extends Modal { className="FormControl" name="password" type="password" + autoComplete="current-password" placeholder={extractText(app.translator.trans('core.forum.log_in.password_placeholder'))} bidi={this.password} disabled={this.loading} From b5e5d7e293d766e7ef8786771e069bca5310dbb0 Mon Sep 17 00:00:00 2001 From: Fransiscus Rolanda Malau Date: Sat, 2 Oct 2021 18:52:59 +0700 Subject: [PATCH 2/3] Add autocomplete attributes to password fields --- js/src/forum/components/ChangeEmailModal.js | 1 + js/src/forum/components/LogInModal.js | 2 +- js/src/forum/components/SignUpModal.js | 1 + views/reset-password.blade.php | 4 ++-- 4 files changed, 5 insertions(+), 3 deletions(-) diff --git a/js/src/forum/components/ChangeEmailModal.js b/js/src/forum/components/ChangeEmailModal.js index 6997e71e0a..3d7cb6ef01 100644 --- a/js/src/forum/components/ChangeEmailModal.js +++ b/js/src/forum/components/ChangeEmailModal.js @@ -77,6 +77,7 @@ export default class ChangeEmailModal extends Modal { type="password" name="password" className="FormControl" + autocomplete="current-password" placeholder={app.translator.trans('core.forum.change_email.confirm_password_placeholder')} bidi={this.password} disabled={this.loading} diff --git a/js/src/forum/components/LogInModal.js b/js/src/forum/components/LogInModal.js index 427aa8fae1..6e2097d343 100644 --- a/js/src/forum/components/LogInModal.js +++ b/js/src/forum/components/LogInModal.js @@ -83,7 +83,7 @@ export default class LogInModal extends Modal { className="FormControl" name="password" type="password" - autoComplete="current-password" + autocomplete="current-password" placeholder={extractText(app.translator.trans('core.forum.log_in.password_placeholder'))} bidi={this.password} disabled={this.loading} diff --git a/js/src/forum/components/SignUpModal.js b/js/src/forum/components/SignUpModal.js index a7c34248cf..edb375fd6a 100644 --- a/js/src/forum/components/SignUpModal.js +++ b/js/src/forum/components/SignUpModal.js @@ -104,6 +104,7 @@ export default class SignUpModal extends Modal { className="FormControl" name="password" type="password" + autocomplete="current-password" placeholder={extractText(app.translator.trans('core.forum.sign_up.password_placeholder'))} bidi={this.password} disabled={this.loading} diff --git a/views/reset-password.blade.php b/views/reset-password.blade.php index 2b389864dd..dfee173831 100644 --- a/views/reset-password.blade.php +++ b/views/reset-password.blade.php @@ -19,11 +19,11 @@

- +

- +

From 5b577e60150dd417eaac3b7b45eecc120d9769c6 Mon Sep 17 00:00:00 2001 From: Fransiscus Rolanda Malau Date: Sat, 2 Oct 2021 20:00:01 +0700 Subject: [PATCH 3/3] Attribute should use new-password --- js/src/forum/components/SignUpModal.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/js/src/forum/components/SignUpModal.js b/js/src/forum/components/SignUpModal.js index edb375fd6a..53593134f6 100644 --- a/js/src/forum/components/SignUpModal.js +++ b/js/src/forum/components/SignUpModal.js @@ -104,7 +104,7 @@ export default class SignUpModal extends Modal { className="FormControl" name="password" type="password" - autocomplete="current-password" + autocomplete="new-password" placeholder={extractText(app.translator.trans('core.forum.sign_up.password_placeholder'))} bidi={this.password} disabled={this.loading}