From 2c5c7a9fc76adfc5c6f867880a3253c1a488b46b Mon Sep 17 00:00:00 2001 From: Alexander Skvortsov Date: Tue, 3 Mar 2020 16:32:55 -0500 Subject: [PATCH 1/3] Added meta title to following page --- js/src/forum/addSubscriptionFilter.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/js/src/forum/addSubscriptionFilter.js b/js/src/forum/addSubscriptionFilter.js index 1bc5d66..abcfe41 100644 --- a/js/src/forum/addSubscriptionFilter.js +++ b/js/src/forum/addSubscriptionFilter.js @@ -18,6 +18,10 @@ export default function addSubscriptionFilter() { } }); + extend(IndexPage.prototype, 'config', function () { + app.setTitle(app.translator.trans('flarum-subscriptions.forum.meta.following_title')); + }); + extend(DiscussionList.prototype, 'requestParams', function(params) { if (this.props.params.filter === 'following') { params.filter.q = (params.filter.q || '') + ' is:following'; From 07067bbe814123e17ffe339139f3e95bf47071f4 Mon Sep 17 00:00:00 2001 From: Alexander Skvortsov Date: Sat, 21 Mar 2020 20:49:35 -0400 Subject: [PATCH 2/3] fixed translation key to comply with guidelines --- js/src/forum/addSubscriptionFilter.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/js/src/forum/addSubscriptionFilter.js b/js/src/forum/addSubscriptionFilter.js index abcfe41..1b4f0c4 100644 --- a/js/src/forum/addSubscriptionFilter.js +++ b/js/src/forum/addSubscriptionFilter.js @@ -19,7 +19,7 @@ export default function addSubscriptionFilter() { }); extend(IndexPage.prototype, 'config', function () { - app.setTitle(app.translator.trans('flarum-subscriptions.forum.meta.following_title')); + app.setTitle(app.translator.trans('flarum-subscriptions.forum.following.meta_title_text')); }); extend(DiscussionList.prototype, 'requestParams', function(params) { From b3d0d7b6d020131a23b105147b5a26e61785a7d2 Mon Sep 17 00:00:00 2001 From: Alexander Skvortsov Date: Sun, 22 Mar 2020 00:16:37 -0400 Subject: [PATCH 3/3] Only apply subscriptions title on subsriptions page --- js/src/forum/addSubscriptionFilter.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/js/src/forum/addSubscriptionFilter.js b/js/src/forum/addSubscriptionFilter.js index 1b4f0c4..9af69ba 100644 --- a/js/src/forum/addSubscriptionFilter.js +++ b/js/src/forum/addSubscriptionFilter.js @@ -19,7 +19,9 @@ export default function addSubscriptionFilter() { }); extend(IndexPage.prototype, 'config', function () { - app.setTitle(app.translator.trans('flarum-subscriptions.forum.following.meta_title_text')); + if (m.route() == "/following") { + app.setTitle(app.translator.trans('flarum-subscriptions.forum.following.meta_title_text')); + } }); extend(DiscussionList.prototype, 'requestParams', function(params) {