Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mac release failures -- box-box intersection #265

Closed
SeanCurtis-TRI opened this issue Mar 9, 2018 · 6 comments
Closed

Mac release failures -- box-box intersection #265

SeanCurtis-TRI opened this issue Mar 9, 2018 · 6 comments
Assignees

Comments

@SeanCurtis-TRI
Copy link
Contributor

PR #259 introduced code that is apparently failing in CI. It specifically fails in mac release builds. Across all tests, no collisions are being reported.

@sherm1
Copy link
Member

sherm1 commented Mar 27, 2018

@mamoll reported this in #271:

Unit tests pass on my Mac, OS X 10.13.3, Xcode 9.2, Boost 1.66 and libccd 2.0 (the last two installed via MacPorts).

@ericberberich
Copy link

ericberberich commented Mar 28, 2018

I have seen test_fcl_capsule_box_1 here on Xcode 9.x - it's the gjksolver instantiated with libccd that produces the wrong result .... the TravisCI for Linux uses libccd 1.5 - so I downgraded to it - but it still appears ... I will have another look into it - any idea which direction to search?

@mamoll you still see the problem or not?

@mamoll
Copy link
Member

mamoll commented Mar 28, 2018

Note that MacPorts installs libccd with double precision by default (-DCCD_DOUBLE=true). Maybe TravisCI has libccd with single precision installed and that's what's causing the failure?

@jslee02
Copy link
Member

jslee02 commented Mar 28, 2018

@geoynomous
Copy link
Contributor

So libccd is always with double precision in all your TravisCI setups?

@SeanCurtis-TRI
Copy link
Contributor Author

This is no longer true. A modicum of archaeology was insufficient to point to the exact solution. So, I'm giving up on that. CI passes; 'nuff said.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants