Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proper unit testing for BVHModel generation from geometric primitives #312

Open
nicovanduijn opened this issue Jul 11, 2018 · 0 comments
Open

Proper unit testing for BVHModel generation from geometric primitives #312

nicovanduijn opened this issue Jul 11, 2018 · 0 comments

Comments

@nicovanduijn
Copy link
Contributor

Following the discussions in #308, we found that there is no adequate unit testing for the generateBVHModel() functions.

Tests needed:

  • Check for geometric correctness
  • Check for correct tessellation
  • Check fault handling for corner cases (radii equal to zero, n=0 etc...)
  • Anything else some knowledgeable person here might know about

A naiive attempt testing just the number of vertices and triangles is here #311
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nicovanduijn