Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] Modal dialog improvements #587

Open
aminick opened this issue Dec 30, 2021 · 0 comments
Open

[UX] Modal dialog improvements #587

aminick opened this issue Dec 30, 2021 · 0 comments
Labels
rel:ux Related to UX type:improvement This is an improvement request

Comments

@aminick
Copy link
Contributor

aminick commented Dec 30, 2021

Kapture 2021-12-30 at 22 38 12

The Modal dialog component can be improved in a few ways:

  1. Focus trap, we can see the background page can be scrolled while the dialog is open
  2. Better WAI-ARIA, this includes ESC keyboard control to close the modal
@aminick aminick changed the title Modal dialog UX improvements [UX] Modal dialog improvements Dec 30, 2021
@aminick aminick added rel:ux Related to UX type:improvement This is an improvement request labels Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rel:ux Related to UX type:improvement This is an improvement request
Projects
None yet
Development

No branches or pull requests

1 participant