Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bitbucket Server support #18

Open
AlexDenisov opened this issue Apr 16, 2018 · 0 comments
Open

Bitbucket Server support #18

AlexDenisov opened this issue Apr 16, 2018 · 0 comments

Comments

@AlexDenisov
Copy link

Hi folks!

It is rather post-mortem than a feature request.

I tried to set up the tool for Bitbucket Server and found that it does not work.
First of all, the method pr_diff does not exist leading to a runtime error.
Secondly, I tried to extend the DangerfileBitbucketServerPlugin and add the pr_diff method, but I found that Bitbucket Server REST API does not support it. In fact, there is a method for that, but it does not return the raw diff. See the example here.

I think it is possible to get it done, but it would require extending the DangerfileBitbucketServerPlugin with pr_diff method and also parsing that JSON format into something consumable by this tool. But I am not sure if it worth the effort for me, so I am leaving this here as a reference to potential future implementors. 😺

Cheers, and keep up the great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants