From 4ff26e8b51d8d51fc7f84cf768c1cda17da5be9e Mon Sep 17 00:00:00 2001 From: Chris Yang Date: Thu, 28 Jan 2021 15:41:52 -0800 Subject: [PATCH 1/2] skip package info --- script/incremental_build.sh | 21 +++++++++++++++++++-- 1 file changed, 19 insertions(+), 2 deletions(-) diff --git a/script/incremental_build.sh b/script/incremental_build.sh index 3911f0a6e9c8..04f4f1f53b6a 100755 --- a/script/incremental_build.sh +++ b/script/incremental_build.sh @@ -14,13 +14,30 @@ else fi # Plugins that are excluded from this task. -ALL_EXCLUDED=("") +ALL_EXCLUDED=() # Exclude nnbd plugins from stable. if [ "$CHANNEL" == "stable" ]; then ALL_EXCLUDED=($EXCLUDED_PLUGINS_FROM_STABLE) - echo "Excluding the following plugins: $ALL_EXCLUDED" fi +readonly FIREBASE_LAB_EXCLUDED_LIST=( + "package_info" +) + +readonly FIREBASE_LAB_EXCLUDED=$(IFS=, ; echo "${FIREBASE_LAB_EXCLUDED_LIST[@]}") +# EXCLUDE plugins in FIREBASE_LAB_EXCLUDED_LIST when the command is firebase-test-lab. +# TODO(cyanglaz): remove this when firebase test lab tests isues are resolved for plugins in FIREBASE_LAB_EXCLUDED_LIST +# https://github.com/flutter/flutter/issues/74944 +if [ "$1" == "firebase-test-lab" ]; then + if [ ${#ALL_EXCLUDED[@]} -eq 0 ]; then + ALL_EXCLUDED=("$FIREBASE_LAB_EXCLUDED") + else + ALL_EXCLUDED=("$ALL_EXCLUDED, $FIREBASE_LAB_EXCLUDED") + fi +fi + +echo "Excluding the following plugins: $ALL_EXCLUDED" + # Plugins that deliberately use their own analysis_options.yaml. # # This list should only be deleted from, never added to. This only exists From dea1afb78b87c92fa3515a2de5d54923ac2b98ed Mon Sep 17 00:00:00 2001 From: Chris Yang Date: Thu, 28 Jan 2021 15:43:34 -0800 Subject: [PATCH 2/2] conditional print --- script/incremental_build.sh | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/script/incremental_build.sh b/script/incremental_build.sh index 04f4f1f53b6a..b6b95c16d5a0 100755 --- a/script/incremental_build.sh +++ b/script/incremental_build.sh @@ -36,7 +36,11 @@ if [ "$1" == "firebase-test-lab" ]; then fi fi -echo "Excluding the following plugins: $ALL_EXCLUDED" +if [ ${#ALL_EXCLUDED[@]} -eq 0 ]; then + ALL_EXCLUDED=("") +else + echo "Excluding the following plugins: $ALL_EXCLUDED" +fi # Plugins that deliberately use their own analysis_options.yaml. #