From f78c8a6d366a42496c009537c9619b92462cf543 Mon Sep 17 00:00:00 2001 From: Nate Bosch Date: Wed, 20 Jan 2021 12:34:01 -0800 Subject: [PATCH 1/2] Pass a URI to package:http API Updates example to be forwards compatible with the breaking change in https://github.com/dart-lang/http/pull/507 --- src/docs/cookbook/networking/fetch-data.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/docs/cookbook/networking/fetch-data.md b/src/docs/cookbook/networking/fetch-data.md index d89aa2af6c..6c5bb3bf1b 100644 --- a/src/docs/cookbook/networking/fetch-data.md +++ b/src/docs/cookbook/networking/fetch-data.md @@ -242,7 +242,7 @@ import 'package:http/http.dart' as http; Future fetchAlbum() async { final response = - await http.get('https://jsonplaceholder.typicode.com/albums/1'); + await http.get(Uri.https('jsonplaceholder.typicode.com', 'albums/1'); if (response.statusCode == 200) { // If the server did return a 200 OK response, From dfb708ad1d03994740f460b0cf712acd0b98b50a Mon Sep 17 00:00:00 2001 From: Nate Bosch Date: Wed, 20 Jan 2021 12:51:01 -0800 Subject: [PATCH 2/2] Other usages. Drop local variable type to match other example --- src/docs/cookbook/networking/fetch-data.md | 2 +- src/docs/cookbook/networking/send-data.md | 10 +++++----- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/docs/cookbook/networking/fetch-data.md b/src/docs/cookbook/networking/fetch-data.md index 6c5bb3bf1b..d2d153f0f1 100644 --- a/src/docs/cookbook/networking/fetch-data.md +++ b/src/docs/cookbook/networking/fetch-data.md @@ -59,7 +59,7 @@ This recipe covers how to fetch a sample album from the ```dart Future fetchAlbum() { - return http.get('https://jsonplaceholder.typicode.com/albums/1'); + return http.get(Uri.https('jsonplaceholder.typicode.com','albums/1')); } ``` diff --git a/src/docs/cookbook/networking/send-data.md b/src/docs/cookbook/networking/send-data.md index f806b7f0bf..05150745e5 100644 --- a/src/docs/cookbook/networking/send-data.md +++ b/src/docs/cookbook/networking/send-data.md @@ -56,7 +56,7 @@ by sending an album title to the ```dart Future createAlbum(String title) { return http.post( - 'https://jsonplaceholder.typicode.com/albums', + Uri.https('jsonplaceholder.typicode.com','albums'), headers: { 'Content-Type': 'application/json; charset=UTF-8', }, @@ -132,8 +132,8 @@ function to return a `Future`: ```dart Future createAlbum(String title) async { - final http.Response response = await http.post( - 'https://jsonplaceholder.typicode.com/albums', + final response = await http.post( + Uri.https('jsonplaceholder.typicode.com','albums'), headers: { 'Content-Type': 'application/json; charset=UTF-8', }, @@ -242,8 +242,8 @@ import 'package:flutter/material.dart'; import 'package:http/http.dart' as http; Future createAlbum(String title) async { - final http.Response response = await http.post( - 'https://jsonplaceholder.typicode.com/albums', + final response = await http.post( + Uri.https('jsonplaceholder.typicode.com','albums'), headers: { 'Content-Type': 'application/json; charset=UTF-8', },