Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

should hifiasm be executed only when user says reads are high quality? #72

Closed
fmalmeida opened this issue Feb 28, 2024 · 1 comment · Fixed by #73
Closed

should hifiasm be executed only when user says reads are high quality? #72

fmalmeida opened this issue Feb 28, 2024 · 1 comment · Fixed by #73
Labels
enhancement New feature or request help wanted Extra attention is needed priority question Further information is requested

Comments

@fmalmeida
Copy link
Owner

fmalmeida commented Feb 28, 2024 •
edited
Loading

The pipeline (in dev branch) now has two params:

--corrected_longreads and high_quality_longreads.

Maybe would be worthy to make hifiasm only run when one of these are available?

This is a follow up of #53

@scintilla9 any strong opinion?
@fmalmeida fmalmeida added enhancement New feature or request help wanted Extra attention is needed question Further information is requested priority labels Feb 28, 2024
@fmalmeida fmalmeida linked a pull request Mar 2, 2024 that will close this issue
Wrap-up version 3.2.0 #73
Merged
@fmalmeida
Copy link
Owner Author

Currently, in the latest release, https://github.com/fmalmeida/MpGAP/releases/tag/v3.2.0, hifiasm is only executed if long reads are said to be corrected or high quality. Otherwise, not.

If a different behaviour is desired in the future, an issue should be opened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed priority question Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Wrap-up version 3.2.0 fmalmeida/MpGAP
1 participant
@fmalmeida