-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Panicked on new platforms (like riscv64gc) if MSRV is too old #585
Comments
Full test log: cargo-msrv-0.15.1-3-riscv64-check.log |
These are all integration tests, which depend on Rustup being able to install the older toolchains. Ideas to resolve the issue:
What do you think the best course of action would be? |
@foresterre I haven't read the code carefully, but I think there should be a way to distinguish if the installation failure is caused by the specified target not existing or any other error. I think skipping all non-existent target errors is a good solution (provided at least one version is installed successfully) so that we can avoid maintaining a minimum support version table for each new architecture. |
In my opinion, cargo-msrv should try to find the minimum supported version binary for a specific arch. Different MSRV on different architecture is more acceptable. We can't ask a developer who working on RISC-V to follow the MSRV generated from x86_64. For example, if there is a new architecture implementation coming in Rust 1.999999 or whatever, developer will not able to compile some crate with rustc v1.999998, so the MSRV for that architecture should be 1.999999. |
I agree. Cargo itself explicitly states that the For a tool like |
The dist riscv64gc became available from version 1.47.0, some tests like find_msrv will fail because
rustup
cannot download the old dist.The text was updated successfully, but these errors were encountered: