Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fmgr_pkg_firewall_policy parameters type correction #49

Open
babakb22 opened this issue Jul 24, 2022 · 5 comments
Open

fmgr_pkg_firewall_policy parameters type correction #49

babakb22 opened this issue Jul 24, 2022 · 5 comments

Comments

@babakb22
Copy link

babakb22 commented Jul 24, 2022

A lot of parameters like dstaddr, service, srcaddr, are of type 'list', but in the module fmgr_pkg_firewall_policy are created as 'str'. This can be easily fixed so that engineers can add a list of source/destination objects, services, etc.

I already tested this myself and works perfectly fine.

Please investigate.

@babakb22 babakb22 changed the title fmgr_pkg_firewall_policy property type correction fmgr_pkg_firewall_policy parameters type correction Jul 24, 2022
@lix-fortinet
Copy link

Hi @babakb22,

Thank you for raising this issue. Team is working on this issue. We will get back to you once it's resolved.

Thanks,
Xing

@matejzero
Copy link

Any update on this issue. It seems like it's still not fixed and we are just deploying a new firewall with fortimanager and want to do whole deployment with ansible. This is a big showstopper at the moment. Any option to push this forward?

@akerkau
Copy link

akerkau commented May 22, 2023

Any update on this issue. It seems like it's still not fixed and we are just deploying a new firewall with fortimanager and want to do whole deployment with ansible. This is a big showstopper at the moment. Any option to push this forward?

While I'm totally with you that this should be fixed: You can use the following parameter to allow the correct datastructures and bypass the wrong str types in the module.

bypass_validation: true

@matejzero
Copy link

Thanks, I went that way and so far it works.

@dux-fortinet
Copy link

Apologies for the inconvenience. Currently, we can't change the type of parameters such as dstaddr, service, srcaddr to 'list', because they are 'str' type in FortiManager v6.x. And Ansible doesn't support declaring a parameter as str and list type at the same time.

You can use bypass_validation: true to avoid this error.

We will change the type of those parameters to 'list' once those old versions of FortiManager are no longer supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants