Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify length semantics for String and KeyValue #21

Closed
defunctzombie opened this issue Jan 14, 2022 · 2 comments
Closed

Clarify length semantics for String and KeyValue #21

defunctzombie opened this issue Jan 14, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@defunctzombie
Copy link
Contributor

The spec says

String: a uint32-prefixed UTF8 string
KeyValues<T1, T2>: A uint32 length-prefixed association of key-value pairs, serialized as

For string is this the length of the string or the number of bytes?
For KeyValues is this the number of pairs or the number of bytes for the remaining serialized portion?
@defunctzombie defunctzombie added the bug Something isn't working label Jan 14, 2022
@defunctzombie
Copy link
Contributor Author

Keep lengths as byte length prefixes - update spec to be more clear where a length is a byte length.

Maybe all places in the spec that are length prefixes are byte length prefixes.

@defunctzombie
Copy link
Contributor Author

Updated in https://github.com/foxglove/mcap/tree/roman/spec-format/docs/specification#string

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Milestone
No milestone
Development

No branches or pull requests
1 participant
@defunctzombie