From a6cb715a1a62f64220b36ae34d7f7a5de08e3f40 Mon Sep 17 00:00:00 2001 From: Ash Wilson Date: Mon, 11 Feb 2019 10:44:41 -0500 Subject: [PATCH 1/3] Temporary spec that crashes, to test crash handling --- spec/goes-boom-spec.js | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 spec/goes-boom-spec.js diff --git a/spec/goes-boom-spec.js b/spec/goes-boom-spec.js new file mode 100644 index 00000000000..41d93ed5da5 --- /dev/null +++ b/spec/goes-boom-spec.js @@ -0,0 +1,5 @@ +describe('crash handler', () => { + it('goes boom', () => { + process.crash() + }) +}) From 6e69bc0d7dea32282790147045fe149a6534ca74 Mon Sep 17 00:00:00 2001 From: Ash Wilson Date: Mon, 11 Feb 2019 10:44:51 -0500 Subject: [PATCH 2/3] Upload crash reports on macOS --- script/vsts/platforms/macos.yml | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/script/vsts/platforms/macos.yml b/script/vsts/platforms/macos.yml index 005f8b96f48..b1e34610fd2 100644 --- a/script/vsts/platforms/macos.yml +++ b/script/vsts/platforms/macos.yml @@ -52,6 +52,12 @@ jobs: cp $(Build.SourcesDirectory)/out/*.zip $(Build.ArtifactStagingDirectory) displayName: Stage Artifacts + - script: | + mkdir -p $(Build.ArtifactStagingDirectory)/crash-reports + cp ${HOME}/Library/Logs/DiagnosticReports/*.crash $(Build.ArtifactStagingDirectory)/crash-reports + displayName: Stage Crash Reports + condition: failed() + - task: PublishBuildArtifacts@1 inputs: PathtoPublish: $(Build.ArtifactStagingDirectory)/atom-mac.zip @@ -75,3 +81,10 @@ jobs: ArtifactType: Container displayName: Upload atom-api.json condition: and(succeeded(), ne(variables['Build.Reason'], 'PullRequest')) + + - task: PublishBuildArtifacts@1 + inputs: + PathtoPublish: $(Build.ArtifactStagingDirectory)/crash-reports + ArtifactName: crash-reports.zip + displayName: Upload Crash Reports + condition: failed() From 8b16801296d8adc70c79382fdfb7dcf379fff6e3 Mon Sep 17 00:00:00 2001 From: Ash Wilson Date: Tue, 12 Feb 2019 11:29:20 -0500 Subject: [PATCH 3/3] Revert "Temporary spec that crashes, to test crash handling" This reverts commit a6cb715a1a62f64220b36ae34d7f7a5de08e3f40. --- spec/goes-boom-spec.js | 5 ----- 1 file changed, 5 deletions(-) delete mode 100644 spec/goes-boom-spec.js diff --git a/spec/goes-boom-spec.js b/spec/goes-boom-spec.js deleted file mode 100644 index 41d93ed5da5..00000000000 --- a/spec/goes-boom-spec.js +++ /dev/null @@ -1,5 +0,0 @@ -describe('crash handler', () => { - it('goes boom', () => { - process.crash() - }) -})