Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better error handling for google social provider #23

Open
dborkan opened this issue Apr 15, 2014 · 1 comment
Open

Better error handling for google social provider #23

dborkan opened this issue Apr 15, 2014 · 1 comment

Comments

@dborkan
Copy link
Contributor

dborkan commented Apr 15, 2014

Possible scenarios: chrome.identity calls fail. Verification of the token (the XHR) fails. etc etc. These should be passed back and social.login(...) should reject with the appropriate error.
@willscott
Copy link
Member

To confirm: this work would be improving the code in demo_google/view-googleauth.js, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@willscott @dborkan