Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Roles Table follow Tenancy #39

Closed
wants to merge 1 commit into from
Closed

Make Roles Table follow Tenancy #39

wants to merge 1 commit into from

Conversation

274188A
Copy link
Contributor

@274188A 274188A commented Sep 3, 2021

function AssignRolesAsync' was just being passed ADMINfor each tenant - but tenants have role-naming likealphaadmin`

function `AssignRolesAsync' was being passes just "ADMIN" for each tenant but tenants have roles like `alphaadmin`
@iammukeshm
Copy link
Member

iammukeshm commented Sep 3, 2021

No, I was planning to do tenant wise separation for the Roles table too.

Role Name - Admin
Tenant - alpha

Role Name - Admin
Tenant - beta

alphaAdmin looks more of a workaround.

Maybe, can you implement it the way I mentioned? I feel it would be more cleaner and will follow tenancy as such.

@iammukeshm iammukeshm closed this Sep 3, 2021
@iammukeshm iammukeshm reopened this Sep 3, 2021
@iammukeshm iammukeshm added enhancement New feature or request high priority High Priority Task labels Sep 3, 2021
@iammukeshm iammukeshm added this to the Release 1.0 milestone Sep 3, 2021
@iammukeshm iammukeshm changed the title Update so correct role name is searched for to assign Make Roles Table follow Tenancy Sep 3, 2021
@iammukeshm iammukeshm linked an issue Sep 3, 2021 that may be closed by this pull request
8 tasks
@iammukeshm iammukeshm removed a link to an issue Sep 3, 2021
8 tasks
@iammukeshm iammukeshm linked an issue Sep 3, 2021 that may be closed by this pull request
2 tasks
@274188A
Copy link
Contributor Author

274188A commented Sep 3, 2021

#40

@274188A 274188A closed this Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request high priority High Priority Task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multi Tenancy
2 participants