returning readonly reference

[jedwards1211]

I've got this method (want to use an immutable object pattern, not concerned about max performance):

  public static Length Create(double value, LengthUnit unit) {
    Length length = new Length();
    length.Set(value, unit);
    return length;
  }

I think this output C++ code leaks memory? I'm not an expert in C++ but I don't see a way that the shared pointer could be released:

const Length * Length::create(double value, LengthUnit unit)
{
	const Length * length = std::make_shared<Length>().get();
	length->set(value, unit);
	return length;
}

[pfusik]

This should be:

public static Length# Create(double value, LengthUnit unit) {
    Length# length = new Length();
    length.Set(value, unit);
    return length;
}

Diagnostics need to be improved - assigning a new object to a non-shared pointer is obviously a leak.

[pfusik]

Error added - it catches cases such as:

Length p = new Length();
Length Create() { return new Length(); }
void Foo(Length length) { } ... Foo(new Length);

with the message:

ERROR: Dynamically allocated object must be assigned to a Length# reference

[jedwards1211]

Thanks! Yeah I understand Length# works, as stated in another issue I'm wanting to use an immutable class pattern and wish I could get a simpler C++ API for it.