Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"version of go" misinterpreted by configure script? #202

Closed
MasterP-theGu opened this issue Sep 4, 2020 · 4 comments · Fixed by #205
Closed

"version of go" misinterpreted by configure script? #202

MasterP-theGu opened this issue Sep 4, 2020 · 4 comments · Fixed by #205
Assignees
@ThomasAdam
Labels
type:bug Something's broken!
Milestone
1.0.1

Comments

@MasterP-theGu
Copy link

Hi,
sorry I haven't had a lot of time recently to keep my fvwm3 up to date and build all versions. I've just built
Version: 1.0.0 (1.0.0-4-gbe72081a)
with --enable-golang option to get fvwm3-prompt working from within the fvwm3 build itself rather than from building it on its own and manually adding it. I haven't had any problem with the new prompt, so my go install seems to suffice for it. the configure output, however, says:
With Golang support? no: version of go (go1.15.1 linux/arm) <= 1.4.x
I find it strange as 1.15.1 looks to me as if it was > than 1.4.x, so either the message or the maths are confusing?
Installed go package is:

Name                     : go
Version                  : 2:1.15.1-1
Beschreibung             : Core compiler tools for the Go programming language
Architektur              : armv7h
URL                      : https://golang.org/
@issue-label-bot
Copy link

Issue Label Bot is not confident enough to auto-label this issue. See dashboard for more details.

ThomasAdam added a commit that referenced this issue Sep 4, 2020
@ThomasAdam
configure.ac: fix golang binary check
ee5465c 
When checking the version of golang, test the major part of the string
(1.XX.yy), and fix up the error message to not mislead the minimum
version.

Fixes #202
@ThomasAdam ThomasAdam mentioned this issue Sep 4, 2020
Merged
@ThomasAdam
Copy link
Member

Hi @MasterP-theGu,

Please take a look at the linked PR. Does this help?

Kindly,
Thomas

ThomasAdam added a commit that referenced this issue Sep 4, 2020
@ThomasAdam
configure.ac: fix golang binary check
efdea86 
When checking the version of golang, test the major part of the string
(1.XX.yy), and fix up the error message to not mislead the minimum
version.

Fixes #202
ThomasAdam added a commit that referenced this issue Sep 5, 2020
@ThomasAdam
configure.ac: fix golang binary check
deb4d2c 
When checking the version of golang, test the major part of the string
(1.XX.yy), and fix up the error message to not mislead the minimum
version.

Fixes #202
@ThomasAdam ThomasAdam added this to the 1.0.1 milestone Sep 5, 2020
@ThomasAdam ThomasAdam added the type:bug Something's broken! label Sep 5, 2020
@ThomasAdam ThomasAdam self-assigned this Sep 5, 2020
@MasterP-theGu
Copy link
Author

Hi @ThomasAdam ,

yes, all's fine now :D Cheers!

Best,
Peter

@ThomasAdam
Copy link
Member

Thanks. Will merge.

ThomasAdam added a commit that referenced this issue Sep 6, 2020
@ThomasAdam
configure.ac: fix golang binary check
44de665 
When checking the version of golang, test the major part of the string
(1.XX.yy), and fix up the error message to not mislead the minimum
version.

Fixes #202
mikeandmore pushed a commit to mikeandmore/fvwm3 that referenced this issue Nov 28, 2020
@ThomasAdam @mikeandmore
configure.ac: fix golang binary check
3fc7d8a 
When checking the version of golang, test the major part of the string
(1.XX.yy), and fix up the error message to not mislead the minimum
version.

Fixes fvwmorg#202
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ThomasAdam ThomasAdam

Labels
type:bug Something's broken!
Projects
FVWM3
Status: Done
Milestone
1.0.1
Development

Successfully merging a pull request may close this issue.

configure.ac: fix golang binary check fvwmorg/fvwm3
2 participants
@ThomasAdam @MasterP-theGu