Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lack of FvwmCommand can break existing configuration #312

Closed
domichel opened this issue Dec 4, 2020 · 7 comments · Fixed by #337
Closed

Lack of FvwmCommand can break existing configuration #312

domichel opened this issue Dec 4, 2020 · 7 comments · Fixed by #337
Assignees
Labels
type:bug Something's broken!
Milestone

Comments

@domichel
Copy link
Contributor

domichel commented Dec 4, 2020

FvwmPrompt replace FvwmCommand. Please provide a FvwmCommand wrapper script to keep the compatibility.

@ThomasAdam ThomasAdam added the type:bug Something's broken! label Dec 4, 2020
@ThomasAdam ThomasAdam added this to the 1.0.2 milestone Dec 4, 2020
@ThomasAdam ThomasAdam removed this from the 1.0.2 milestone Dec 5, 2020
@ThomasAdam
Copy link
Member

Hi @domichel

Indeed. I think it's easier to start a fvwm-convert-3.0 script which builds on fvwm-convert-2.6.

I will close this for now, until that script appears. I might look at it later on.

@NsCDE
Copy link
Contributor

NsCDE commented Dec 6, 2020

Hi

I will like to propose solution here, based on my views.

FvwmMFL basically replaced FvwmCommandS and it is building more functionality than old message command system has. This is good.

I think Dominique has right here. FvwmCommand was compiled binary in FVWM2. Removing it without providing a wrapper can be annoying for users while migrating. By it's nature, FvwmCommand is/was often not called within FVWM_USERDIR, this can be called from scripts run by user in ~/bin, from cron, various launcers ... many possibilities here.

I personally, don't have this problem. I have made nscde_fvwmclnt which talks with FvwmMFL and made it retroactive wrapper for FvwmCommand if FVWM2 is detected, so one unified interface is used to send commands to FVWM, regardless of major version. Dominique can build on this too possibly, but I see problems for users who are not using hybrid DEs like NsCE or Crystal, who has scripts which expects that something with name "FvwmCommand" exists. Some wrapper in Python or Perl if Go is not supported (and often it is still problematic) would be nice to make life easier to existing user base.

My two cents just .... :-)

@ThomasAdam
Copy link
Member

Hi,

So why don't I include nscde_fvwmclnt in Fvwm3 as FvwmCommand? Eventually, this will just be a symlink to FvwmPrompt when I'm able to do that.

@NsCDE -- feel free to submit a PR to achieve this if you have the time. I would put this wrapper in bin/FvwmPrompt and allow it to install to the same place as FvwmPrompt does. We will need a mention of this in FvwmPrompt's man page entry as well.

@NsCDE
Copy link
Contributor

NsCDE commented Dec 6, 2020

Ok. I will look at it later and clean it from NsCDE-isms for general use.

@ThomasAdam
Copy link
Member

I had originally suggested using;

#!/bin/sh

echo "$@" | nc -q1 -U "$FVWMMFL_SOCKET"

... but this relies on the version of nc being BSD-compatible which not every Linux distro will use.

Happy for this to be in python3 instead (inline with the version of python we check for in fvwm3 already) if that's more portable.

@ThomasAdam ThomasAdam added this to the 1.0.2 milestone Dec 6, 2020
@NsCDE
Copy link
Contributor

NsCDE commented Dec 8, 2020

Yes, entity "nc" can accept different options depending of it's origin and version.

BTW, how do you prefer FvwmMFL client based on nscde_fvwmclnt delivered? As FvwmCommand or as some other name and then symlinked to FvwmCommand?

@ThomasAdam
Copy link
Member

Hi @NsCDE

You can call the client FvwmCommand, that's fine.

NsCDE added a commit to NsCDE/fvwm3 that referenced this issue Dec 9, 2020
When FvwmCommand was removed in favour of using FvwmPrompt, there was no legacy wrapper for maintaing FvwmCommand.
Reintroduce this as a wrapper against FvwmMFL.
Fixes fvwmorg#312
ThomasAdam pushed a commit that referenced this issue Dec 9, 2020
When FvwmCommand was removed in favour of using FvwmPrompt, there was no legacy wrapper for maintaing FvwmCommand.
Reintroduce this as a wrapper against FvwmMFL.

Fixes #312
NsCDE added a commit to NsCDE/fvwm3 that referenced this issue Dec 9, 2020
When FvwmCommand was removed in favour of using FvwmPrompt, there was no legacy wrapper for maintaing FvwmCommand.
Reintroduce this as a wrapper against FvwmMFL.
Fixes fvwmorg#312
@ThomasAdam ThomasAdam linked a pull request Dec 9, 2020 that will close this issue
ThomasAdam pushed a commit that referenced this issue Dec 9, 2020
When FvwmCommand was removed in favour of using FvwmPrompt, there was no legacy wrapper for maintaing FvwmCommand.
Reintroduce this as a wrapper against FvwmMFL.
Fixes #312
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something's broken!
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants