FvwmPager: per-monitor improvements #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomasAdam
force-pushed
the
ta/fvwmpager-per-monitor
branch
from
917e0fc
to
96dd53e
Compare
ThomasAdam
force-pushed
the
ta/fvwmpager-per-monitor
branch
6 times, most recently
from
fe80e4a
to
b77a17b
Compare
When FvwmPager is in "per-monitor" mode (that is, been configured with "*FvwmPager: Monitor <name>"), it is only ever useful to show the windows which are on that monitor. To achieve this, we therfore need to translate the windows's coordinates to the bounding "view" the monitor the window is on has (that is, its own width/height). Translate the window's position (which is relative to the entire XServer display) to the appropriate monitor, and keep tracking where it is. This rewrites the CalcGeom() function which previously used a "mirroring" technique to reflect the bounds of the window in the pager. Helps #44
Don't kill FvwmPager if there's too many missed XEvents. These are weeded out during scrolling, and hence the original check is no longer required.
ThomasAdam
force-pushed
the
ta/fvwmpager-per-monitor
branch
from
05033ea
to
ee91278
Compare
The copyright licence on FVWM is GPL, and as such Robert Nation has already given his blessing for that. Hence, this notice doesn't need to be in the man page. Similar messages in comments in code elsewhere have already been removed.
Describe what "*FvwmPager: Monitor xxx" does.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.