better checks for icon size

[mikeandmore]

Some icons are not following the XDG standard (nautilus for example). This patch uses the identity program to check the icon size.

[ThomasAdam]

Hi @mikeandmore,

Thanks. However, I do not want there to be a dependency on this script to use imagemagick -- I think that's overkill.

I am sure there's a better way of doing this.

[mikeandmore]

Yeah. The current script already uses convert, which is also from ImageMagick. We are already depending on ImageMagick (or GraphicsMagick).

Do you think it's a good idea to use PIL (Python Image Library)?

[ThomasAdam]

Do you think it's a good idea to use PIL (Python Image Library)?

If you can make that work, by:

• Removing any assumed dependence on Imagemagick;
• Make PIL a dependency check at runtime for fvwm-menu-desktop (so that it's not a hard dependency at build-time for FVWM3`

That'd be even better!

Thanks,
Thomas

[mikeandmore]

Well...This is not easy. PIL doesn't support SVGs. To support SVGs, we need to introduce another SVG library that converts to PNG.

The most commonly used SVG library on Linux seems to be cairo and rsvg, but that means we are depending on cairo-cffi, rsvg, and gobject-introspection just for SVG support.

[mikeandmore]

OK, this patch now uses PIL or ImageMagick to scale icons. Depending on what's on the system already.

PIL is slightly faster.