Update to config #137
Merged
Update to config #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lgsobalvarro
commented
Jun 24, 2020
lgsobalvarro
commented
- IconMan now uses colorset 10 instead 0, to honor Wiki conventions (Thanks to somiaj)
- dmenu_run uses -nb '#2b4e5e' so it'll integrate better with the new colorset (Suggestion by Master_P_the_Gu)
- Edited menu option xemacs for emacs since xemacs is in maintenance mode and emacs seems to be more popular this days.
pull from fvwmorg
ThomasAdam
requested changes
Jun 24, 2020
There was a problem hiding this comment.
Hi @lgsobalvarro,
Thanks for this! Aside from my comments herein, everything else looks good.
default-config/config
Outdated
| @@ -285,7 +285,7 @@ AddToMenu MenuFvwmRoot "Fvwm" Title | |||
| + "&Programs%icons/programs.png%" Popup MenuPrograms | |||
| + "XDG &Menu%icons/apps.png%" Popup XDGMenu | |||
| + "&XTerm%icons/terminal.png%" Exec exec $[infostore.terminal] | |||
| Test (x dmenu_run) + "Run command" Exec exec dmenu_run | |||
| Test (x dmenu_run) + "Run command" Exec exec dmenu_run -nb "#2b4e5e" | |||
There was a problem hiding this comment.
We should move this colour definition to using infostore, and use it here.
There was a problem hiding this comment.
That's a good suggestion, it would simplify things. Do you suggest only changing the color definition or use infostore for the full command? Perhaps the full command option could be more convenient for those who want to switch to Rofi or something.
There was a problem hiding this comment.
Sure. Even better. Go for it!
default-config/config
Outdated
| @@ -462,7 +462,7 @@ Silent Key F2 A C GotoDesk 0 1 | |||
| Silent Key F3 A C GotoDesk 0 2 | |||
| Silent Key F4 A C GotoDesk 0 3 | |||
| Silent Key Super_R A A Exec exec $[infostore.terminal] | |||
| Silent Key Space A M Exec exec dmenu_run | |||
| Silent Key Space A M Exec exec dmenu_run -nb "#2b4e5e" | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.