Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure.ac: look for golang #190

Merged
merged 2 commits into from
Aug 25, 2020
Merged

configure.ac: look for golang #190

merged 2 commits into from
Aug 25, 2020

Conversation

ThomasAdam
Copy link
Member

Add the required checks to look for golang. Off by default, so needs
--enable-golang explicitly in order to work. Will be used to compile
Fvwm3 modules written in Go, without making this a core dependency.

Add the required checks to look for golang.  Off by default, so needs
--enable-golang explicitly in order to work.  Will be used to compile
Fvwm3 modules written in Go, without making this a core dependency.
@ThomasAdam ThomasAdam force-pushed the ta/add-fvwmprompt branch 2 times, most recently from 914f4f9 to 87b1a37 Compare August 25, 2020 11:47
This introduces a new command, FvwmPrompt, as a replacement for
FvwmConsole and FvwmCommand.

As a replacement for FvwmCommand, it can be run as:

    FvwmPrompt 'fvwm command here'

As a replacement for FvwmConsole, it can be run as:

    FvwmPrompt

Unlike FvwmConsole, FvwmPrompt is a standalone program communicating
with FvwmMFL, and is not therefore a Fvwm module.  As such, FvwmPrompt
does not accept the same command-line arguments as FvwmConsole to get it
to launch a specific terminal (-terminal), for example.  Instead, a
compat-friendly shell alias is recommended (but not provided):

   alias FvwmConsole='xterm -g 80x24 -e FvwmPrompt'

This also means that FvwmPrompt does not need to be started from FVWM
either, and will work as long as "Module FvwmMFL" is running.  This is
the case by default, and hence no configuration changes should be
required to make FvwmMFL load.

To enable FvwmPrompt, autotools will look for the Go runtime installed
on the system, and must be at a version >= 1.4.x.  It must also be told
to do this, via --enable-golang, as in:

    ./configure --enable-golang

It is expected in the future that more modules could be written in Go,
hence this option.  It is not currently mandatory that Go needs to be
installed, hence this configure flag.

If '--enable-golang' is used, and configure checks pass, then this
explicitly bypasses compiling and installing FvwmConsole.  This is a
compatibility feature only for now, until such time that confidence in
FvwmPrompt's use and surrounding tooling on different platforms (BSDs
mostly) is met without any large overhead for package maintainers.
@ThomasAdam ThomasAdam marked this pull request as ready for review August 25, 2020 12:10
@ThomasAdam ThomasAdam added this to the 1.0 milestone Aug 25, 2020
@ThomasAdam ThomasAdam merged commit 09f38d8 into master Aug 25, 2020
@ThomasAdam ThomasAdam deleted the ta/add-fvwmprompt branch August 25, 2020 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant