Add support for triangle indicator in/out sub options #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomasAdam
reviewed
Sep 10, 2020
modules/FvwmButtons/parse.c
Outdated
Comment on lines
525
to
529
| clear_comma = strchr(indicator_in_out, ','); | ||
| if (clear_comma != NULL) | ||
| { | ||
| *clear_comma = '\0'; | ||
| } |
There was a problem hiding this comment.
Maybe:
Suggested change
| clear_comma = strchr(indicator_in_out, ','); | |
| if (clear_comma != NULL) | |
| { | |
| *clear_comma = '\0'; | |
| } | |
| indicator_in_out[strcspn(indicator_in_out, ",")] = '\0'; |
ThomasAdam
reviewed
Sep 10, 2020
|
Hi, I have implemented your first suggestion. But I cannot find the second one in the code. I'm bit disoriented now. Also for size limits ... how many to put for this ... please resolve if you can. :-) |
ThomasAdam
approved these changes
Sep 10, 2020
|
Hi @NsCDE, Not a problem. We'll monitor this for now. Let's see how we get on! Merged now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Thomas. This is my long existing patch 2/3 it messes with the same files as window name patch, so I have split it and sent as separate patch.
What does it do: it adds ability for subpanel launcher triangle indicator to be drawn in 3D sunken in, not just raised out. This means that indicator has new argument - after positive integer, there can be keyword "in" or "out". Absence of this argument means "out" which is visual and configuration parsing backward compatible behaviour.
A small illustration attached: right is default raised triangle, left is sunken in new option.
