libs: remove CatString2/CatString3 #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CatString2 and CatString3 provided a means of concatenating either two
or three variables together. However, the callers of these don't get to
specify a format string, as in:
"%s %s"
which breaks compiling fvwm3 with:
CFLAGS="-Wformat -Werror=format-security"
Given these wrappers are inflexible, and that xasprintf() already exists
in the codebase, switch to using that.
Fixes #334
ThomasAdam
force-pushed
the
ta/gh-334
branch
from
ffae2c3
to
805ec9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CatString2 and CatString3 provided a means of concatenating either two
or three variables together. However, the callers of these don't get to
specify a format string, as in:
which breaks compiling fvwm3 with:
Given these wrappers are inflexible, and that xasprintf() already exists
in the codebase, switch to using that.
Fixes #334