Deprecate HAVE_XRandR/FScreenIsEnabled() #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because support in X11 Xorg is prevalent for the RandR protocol, fvwm3 has mandated for some time that RandR is a required dependency, and not optional. Thus, remove surrounding guards for '#ifdef HAVE_XRANDR' as they're no longer needed.
In fvwm2, Xinerama support was optional, and as such, fvwmlib had to predicate against that by callers using FScreenIsEnabled(). However, since RandR support is now mandatory, this function is no longer required.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that RandR is mandatory in
Fvwm3, remove the HAVE_XRANDR guards, as wellas FScreenIsEnabled() function from libfvwm3, as they're no longer required.