PanFrames: handle DesktopConfiguration changes #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomasAdam
force-pushed
the
ta/panframe-improvements
branch
from
05355da
to
b368a06
Compare
When `DesktopConfigutation` is toggled between `global` and `per-monitor` ensure that the cursor in the panframes are reset correctly. This wasn't happening for `global` mode.
ThomasAdam
force-pushed
the
ta/panframe-improvements
branch
from
b368a06
to
ff45d3c
Compare
ThomasAdam
changed the title
ThomasAdam
force-pushed
the
ta/panframe-improvements
branch
from
ff45d3c
to
e3146e6
Compare
When panframes are created, the DesktopConfiguration is taken in to account. This means that during startup, the panframes will be initialised in the global state, but could change to being per-monitor shortly afterward. The implementation assumed that all monitors would needed to have been checked, however this isn't true in the case of per-monitor mode; as a result, panframes around other monitors were being unmapped. Instead, callers of checkPanFrames() already know which monitor needs to be involved and can pass that through. This change removes the previous should_free_panframe() call as it's never used from more than one place, so can be inlined once more. In doing so, s/Bool/bool/ since Bool is reserved for X11 purposes. Fixes #381, fixes #401
ThomasAdam
force-pushed
the
ta/panframe-improvements
branch
from
e3146e6
to
ab8d630
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When panframes are created, the DesktopConfiguration is taken in to
account. This means that during startup, the panframes will be
initialised in the global state, but could change to being per-monitor
shortly afterward.
The implementation assumed that all monitors would needed to have been
checked, however this isn't true in the case of per-monitor mode; as a
result, panframes around other monitors were being unmapped.
Instead, callers of checkPanFrames() already know which monitor needs to
be involved and can pass that through. This change removes the previous
should_free_panframe() call as it's never used from more than one place,
so can be inlined once more. In doing so, s/Bool/bool/ since Bool is
reserved for X11 purposes.
Fixes #381, fixes #401