PanFrame improvements #460
Merged
+41
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When handling paging, seaprate out the logic more distinctly for where the pointer should end up when panning; sometimes, the cursor would end up near the middle of two displays which is fine for per-monitor mode, but not for global. Fixes #459
When paging is initiated through the use of panframes, they are mapped and unmapped accordingly. When `DesktopConfiguration` is in `global` mode (the default), the global state aggregated across all monitors is updated. This update didn't include the state of panwindows, which meant that once someone had caused paging to happen enough time, panframes which should have been mapped weren't. Fixes #459
When calculating if the edge_thickness has changed, it's saved for comparison and put back afterwards. This wasn't happening in all cases for per-monitor mode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses some observations in #459: