ta/gh 477 #478
Merged
ta/gh 477 #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ThomasAdam
commented
Apr 17, 2021
ThomasAdam
commented
- EWMH: SetDesktopNames should set num of desks
- UPDATE_FVWM_SCREEN: update EWMH desktop
FVWM was one of the first WMs to adopt the EWMH specification alongside the ICCCM2 specification. As such, some of the means of specifying things like number of desktops can come about in a few different ways. The `DesktopName` command sets the names of each desktop (and therefore implicitly how many desktops there are), but there's also a `EwmhNumberOfDesktops` command to do the same thing. Regardless of which command a user choses, `DesktopName` should set the NumberOfDesktops variable which calculates how many desktops there actually are. Fixes #477
When a window is dragged between monitors, update the EWMH current desk if it differs, so that the true current desk is updated. This has the (correct, IMO) consequence that the current EWMH desktop changes depending on which screena command such as `xprop -root -spy | rg _NET_CURRENT` is run from. However, in the case of `DesktopConfiguration` being set to `shared` or `per-monitor`, this should always be the case, as each monitor is allowed to be on different desktops. Fixes #477
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.